Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing clippy warnings #397

Closed
wants to merge 4 commits into from
Closed

Fixing clippy warnings #397

wants to merge 4 commits into from

Conversation

Saran51
Copy link

@Saran51 Saran51 commented Oct 1, 2021 •
edited

What this PR does / why we need it:
This PR is fixing the clippy warnings closes #383

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • version has been updated appropriately (./version.sh)

@ghost
Copy link

ghost commented Oct 1, 2021 •
edited by ghost

CLA assistant check
All CLA requirements met.

bfjelds
bfjelds reviewed Oct 4, 2021
View reviewed changes
clippy.toml
@@ -0,0 +1 @@
too-many-arguments-threshold = 10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there a lot of functions that have more than the default number of arguments?

@kate-goldenring
Copy link
Contributor

@Saran51 let us know if you are hitting any roadblocks here

@github-actions
Copy link
Contributor

PR has been automatically marked as stale due to inactivity for 90 days. Update the PR to remove label, otherwise it will be automatically closed."

@github-actions github-actions bot added the stale label Jan 17, 2022
@kate-goldenring
Copy link
Contributor

@Saran51 should we let this close out or do you think you will be able to come back to the PR?

@github-actions github-actions bot removed the stale label Jan 19, 2022
@kate-goldenring
Copy link
Contributor

closing in favor of #442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfjelds bfjelds bfjelds left review comments

@Britel Britel Awaiting requested review from Britel Britel is a code owner

@jiria jiria Awaiting requested review from jiria jiria is a code owner

@kate-goldenring kate-goldenring Awaiting requested review from kate-goldenring kate-goldenring is a code owner

@romoh romoh Awaiting requested review from romoh romoh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix cargo clippy warnings
3 participants
@Saran51 @kate-goldenring @bfjelds