Fixing clippy warnings

.github/workflows/check-rust.yml

@@ -46,6 +46,8 @@ jobs:
       run: cargo fmt --all -- --check
     - name: Check clippy
       run: cargo clippy --all
+    - name: Check clippy for tests
+      run: cargo clippy --all-targets --all-features -- -D warnings
     - name: Run check
       run:  cargo check
     - name: Check for H2 patch not being applied
@@ -58,3 +60,4 @@ jobs:
       run: cargo test -- --ignored
     - name: Run doc
       run: cargo doc --no-deps
+

agent/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "agent"
-version = "0.6.20"
+version = "0.6.21"
 authors = ["Kate Goldenring <kate.goldenring@microsoft.com>", "<bfjelds@microsoft.com>"]
 edition = "2018"
 

clippy.toml

@@ -0,0 +1 @@
+too-many-arguments-threshold = 10

controller/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "controller"
-version = "0.6.20"
+version = "0.6.21"
 authors = ["<bfjelds@microsoft.com>"]
 edition = "2018"
 

deployment/helm/Chart.yaml

@@ -15,9 +15,9 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.6.20
+version: 0.6.21
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
-appVersion: 0.6.20
+appVersion: 0.6.21

discovery-handler-modules/debug-echo-discovery-handler/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "debug-echo-discovery-handler"
-version = "0.6.20"
+version = "0.6.21"
 authors = ["Kate Goldenring <kate.goldenring@microsoft.com>"]
 edition = "2018"
 

discovery-handler-modules/onvif-discovery-handler/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "onvif-discovery-handler"
-version = "0.6.20"
+version = "0.6.21"
 authors = ["Kate Goldenring <kate.goldenring@microsoft.com>"]
 edition = "2018"
 

discovery-handler-modules/opcua-discovery-handler/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "opcua-discovery-handler"
-version = "0.6.20"
+version = "0.6.21"
 authors = ["Kate Goldenring <kate.goldenring@microsoft.com>"]
 edition = "2018"
 

discovery-handler-modules/udev-discovery-handler/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "udev-discovery-handler"
-version = "0.6.20"
+version = "0.6.21"
 authors = ["Kate Goldenring <kate.goldenring@microsoft.com>"]
 edition = "2018"
 

discovery-handlers/debug-echo/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "akri-debug-echo"
-version = "0.6.20"
+version = "0.6.21"
 authors = ["Kate Goldenring <kate.goldenring@microsoft.com>"]
 edition = "2018"
 

discovery-handlers/onvif/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "akri-onvif"
-version = "0.6.20"
+version = "0.6.21"
 authors = ["Kate Goldenring <kate.goldenring@microsoft.com>"]
 edition = "2018"
 

discovery-handlers/onvif/src/discovery_handler.rs

@@ -108,7 +108,7 @@ impl DiscoveryHandler for DiscoveryHandlerImpl {
                 let futures: Vec<_> = latest_cameras
                     .iter()
                     .filter(|c| !previous_cameras.contains(c))
-                    .map(|c| apply_filters(&discovery_handler_config, &c, &onvif_query))
+                    .map(|c| apply_filters(&discovery_handler_config, c, &onvif_query))
                     .collect();
                 let options = futures_util::future::join_all(futures).await;
                 // Insert newly discovered camera that are not filtered out
@@ -154,7 +154,7 @@ async fn apply_filters(
 ) -> Option<(String, Device)> {
     info!("apply_filters - device service url {}", device_service_uri);
     let (ip_address, mac_address) = match onvif_query
-        .get_device_ip_and_mac_address(&device_service_uri)
+        .get_device_ip_and_mac_address(device_service_uri)
         .await
     {
         Ok(ip_and_mac) => ip_and_mac,

discovery-handlers/onvif/src/discovery_impl.rs

@@ -304,7 +304,7 @@ pub mod util {
 
         let envelope_as_string = create_onvif_discovery_message(&uuid_str);
         socket
-            .send_to(&envelope_as_string.as_bytes(), multi_socket_addr)
+            .send_to(envelope_as_string.as_bytes(), multi_socket_addr)
             .await?;
         Ok(socket)
     }

discovery-handlers/onvif/src/discovery_utils.rs

@@ -364,7 +364,7 @@ async fn inner_get_device_profile_streaming_uri(
 /// Gets the streaming uri for a given profile for an ONVIF camera
 async fn inner_is_device_responding(url: &str, http: &impl Http) -> Result<String, anyhow::Error> {
     http.post(
-        &url,
+        url,
         &get_action(DEVICE_WSDL, "GetSystemDateAndTime"),
         &GET_SYSTEM_DATE_AND_TIME_TEMPLATE.to_string(),
     )

discovery-handlers/opcua/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "akri-opcua"
-version = "0.6.20"
+version = "0.6.21"
 authors = ["Kate Goldenring <kate.goldenring@microsoft.com>"]
 edition = "2018"
 

discovery-handlers/udev/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "akri-udev"
-version = "0.6.20"
+version = "0.6.21"
 authors = ["Kate Goldenring <kate.goldenring@microsoft.com>"]
 edition = "2018"
 

discovery-utils/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "akri-discovery-utils"
-version = "0.6.20"
+version = "0.6.21"
 authors = ["Kate Goldenring <kate.goldenring@microsoft.com>"]
 edition = "2018"
 

samples/brokers/udev-video-broker/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "udev-video-broker"
-version = "0.6.20"
+version = "0.6.21"
 authors = ["Kate Goldenring <kate.goldenring@microsoft.com>", "<bfjelds@microsoft.com>"]
 edition = "2018"
 

shared/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "akri-shared"
-version = "0.6.20"
+version = "0.6.21"
 authors = ["<bfjelds@microsoft.com>"]
 edition = "2018"
 

shared/src/akri/instance.rs

@@ -383,7 +383,7 @@ mod crd_serializeation_tests {
         let deserialized: InstanceSpec = serde_json::from_str(json).unwrap();
         assert_eq!("blah".to_string(), deserialized.configuration_name);
         assert_eq!(1, deserialized.broker_properties.len());
-        assert_eq!(true, deserialized.shared);
+        assert!(deserialized.shared);
         assert_eq!(2, deserialized.nodes.len());
         assert_eq!(2, deserialized.device_usage.len());
 

shared/src/k8s/mod.rs

@@ -585,8 +585,8 @@ pub mod test_ownership {
             ownership.get_api_version()
         );
         assert_eq!("Configuration", &ownership.get_kind());
-        assert_eq!(true, ownership.get_controller().unwrap());
-        assert_eq!(true, ownership.get_block_owner_deletion().unwrap());
+        assert!(ownership.get_controller().unwrap());
+        assert!(ownership.get_block_owner_deletion().unwrap());
         assert_eq!(name, &ownership.get_name());
         assert_eq!(uid, &ownership.get_uid());
     }
@@ -601,8 +601,8 @@ pub mod test_ownership {
             ownership.get_api_version()
         );
         assert_eq!("Instance", &ownership.get_kind());
-        assert_eq!(true, ownership.get_controller().unwrap());
-        assert_eq!(true, ownership.get_block_owner_deletion().unwrap());
+        assert!(ownership.get_controller().unwrap());
+        assert!(ownership.get_block_owner_deletion().unwrap());
         assert_eq!(name, &ownership.get_name());
         assert_eq!(uid, &ownership.get_uid());
     }
@@ -613,8 +613,8 @@ pub mod test_ownership {
         let ownership = OwnershipInfo::new(OwnershipType::Pod, name.to_string(), uid.to_string());
         assert_eq!("core/v1", ownership.get_api_version());
         assert_eq!("Pod", &ownership.get_kind());
-        assert_eq!(true, ownership.get_controller().unwrap());
-        assert_eq!(true, ownership.get_block_owner_deletion().unwrap());
+        assert!(ownership.get_controller().unwrap());
+        assert!(ownership.get_block_owner_deletion().unwrap());
         assert_eq!(name, &ownership.get_name());
         assert_eq!(uid, &ownership.get_uid());
     }
@@ -626,8 +626,8 @@ pub mod test_ownership {
             OwnershipInfo::new(OwnershipType::Service, name.to_string(), uid.to_string());
         assert_eq!("core/v1", ownership.get_api_version());
         assert_eq!("Service", &ownership.get_kind());
-        assert_eq!(true, ownership.get_controller().unwrap());
-        assert_eq!(true, ownership.get_block_owner_deletion().unwrap());
+        assert!(ownership.get_controller().unwrap());
+        assert!(ownership.get_block_owner_deletion().unwrap());
         assert_eq!(name, &ownership.get_name());
         assert_eq!(uid, &ownership.get_uid());
     }

version.txt

@@ -1 +1 @@
-0.6.20
+0.6.21

webhooks/validating/configuration/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "webhook-configuration"
-version = "0.6.20"
+version = "0.6.21"
 authors = ["DazWilkin <daz.wilkin@gmail.com>"]
 edition = "2018"