Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the HTTP Request parser to add Support for Signature Validation via HTTP Header #6

Closed
husseinfakharany opened this issue Apr 26, 2022 · 0 comments · Fixed by #8
Closed

Implement the HTTP Request parser to add Support for Signature Validation via HTTP Header #6

husseinfakharany opened this issue Apr 26, 2022 · 0 comments · Fixed by #8
Assignees
@husseinfakharany
Labels
enhancement New feature or request

Comments

@husseinfakharany
Copy link
Collaborator

In order to add support for PKI signature validation via the HTTP header, we should implement the parser which, assuming the relevant Signature and Signature-Input headers are present, should build the seed from the Signature-Input, parse the key-id and algorithm used in the signing process, as well as the signature from the request.

Original issue for context: project-alvarium/alvarium-sdk-go#25

Relevant Go SDK PR: project-alvarium/alvarium-sdk-go#29
@husseinfakharany husseinfakharany self-assigned this Apr 26, 2022
@husseinfakharany husseinfakharany added the enhancement New feature or request label Apr 26, 2022
husseinfakharany added a commit to husseinfakharany/alvarium-sdk-python that referenced this issue Apr 28, 2022
@husseinfakharany @ramezmoussa @GannaWalaa
Add Support for Signature Validation via HTTP
99b5aa5 
* Implement HTTP request parser in handler/base.go and related
 exceptions and tests
* Implement request handler interface and factory
* Implement ED25519 request handler and related test
* Modify annotator factory to accomodate the new HTTPPKI annotator
* Implement httppki annotator and related tests

Fix project-alvarium#4
Fix project-alvarium#6
Fix project-alvarium#7

Co-authored-by: Ramez Moussa <ramez.moussa@aucegypt.edu>
Co-authored-by: Ganna Walaa <gannawalaa@gmail.com>
Signed-off-by: husseinfakharany <fakharany.hussein@gmail.com>
@husseinfakharany husseinfakharany mentioned this issue Apr 28, 2022
Merged
husseinfakharany added a commit to husseinfakharany/alvarium-sdk-python that referenced this issue May 12, 2022
@husseinfakharany @ramezmoussa @GannaWalaa
Add Support for Signature Validation via HTTP
603d1e6 
* Implement HTTP request parser in handler/base.go and related
 exceptions and tests
* Implement request handler interface and factory
* Implement ED25519 request handler and related test
* Modify annotator factory to accomodate the new HTTPPKI annotator
* Implement httppki annotator and related tests

Fix project-alvarium#4
Fix project-alvarium#6
Fix project-alvarium#7

Co-authored-by: Ramez Moussa <ramez.moussa@aucegypt.edu>
Co-authored-by: Ganna Walaa <gannawalaa@gmail.com>
Signed-off-by: husseinfakharany <fakharany.hussein@gmail.com>
husseinfakharany added a commit to husseinfakharany/alvarium-sdk-python that referenced this issue May 15, 2022
@husseinfakharany @ramezmoussa @GannaWalaa
Add Support for Signature Validation via HTTP
3add25a 
* Implement HTTP request parser in handler/base.go and related
 exceptions and tests
* Implement request handler interface and factory
* Implement ED25519 request handler and related test
* Modify annotator factory to accomodate the new HTTPPKI annotator
* Implement httppki annotator and related tests

Fix project-alvarium#4
Fix project-alvarium#6
Fix project-alvarium#7

Co-authored-by: Ramez Moussa <ramez.moussa@aucegypt.edu>
Co-authored-by: Ganna Walaa <gannawalaa@gmail.com>
Signed-off-by: husseinfakharany <fakharany.hussein@gmail.com>
husseinfakharany added a commit to husseinfakharany/alvarium-sdk-python that referenced this issue May 15, 2022
@husseinfakharany @ramezmoussa @GannaWalaa
Add Support for Signature Validation via HTTP
00ffe20 
* Implement HTTP request parser in handler/base.go and related
 exceptions and tests
* Implement request handler interface and factory
* Implement ED25519 request handler and related test
* Modify annotator factory to accomodate the new HTTPPKI annotator
* Implement httppki annotator and related tests

Fix project-alvarium#4
Fix project-alvarium#6
Fix project-alvarium#7

Co-authored-by: Ramez Moussa <ramez.moussa@aucegypt.edu>
Co-authored-by: Ganna Walaa <gannawalaa@gmail.com>
Signed-off-by: husseinfakharany <fakharany.hussein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@husseinfakharany husseinfakharany

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Support for Signature Validation via HTTP husseinfakharany/alvarium-sdk-python
1 participant
@husseinfakharany