Add Support for Signature Validation via HTTP #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
husseinfakharany
force-pushed
the
issue_4
branch
from
b15c05c
to
99b5aa5
Compare
husseinfakharany
requested review from
NayeraMohamed,
KarimElghamry and
tsconn23
KarimElghamry
requested changes
May 15, 2022
KarimElghamry
requested changes
May 15, 2022
* Implement HTTP request parser in handler/base.go and related exceptions and tests * Implement request handler interface and factory * Implement ED25519 request handler and related test * Modify annotator factory to accomodate the new HTTPPKI annotator * Implement httppki annotator and related tests Fix project-alvarium#4 Fix project-alvarium#6 Fix project-alvarium#7 Co-authored-by: Ramez Moussa <ramez.moussa@aucegypt.edu> Co-authored-by: Ganna Walaa <gannawalaa@gmail.com> Signed-off-by: husseinfakharany <fakharany.hussein@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exceptions and tests
Fix #4
Fix #6
Fix #7
Co-authored-by: Ramez Moussa ramez.moussa@aucegypt.edu
Co-authored-by: Ganna Walaa gannawalaa@gmail.com
Signed-off-by: husseinfakharany fakharany.hussein@gmail.com