Skip to content

Commit

Permalink
Remove non-Matter door lock bits from door lock XML. (#19063)
Browse files Browse the repository at this point in the history
* The LOG feature is "[Zigbee]" in the device library, and the Door Lock cluster
  spec says: "If Events are supported the logging feature SHALL NOT be
  supported.".  That means the following attributes are not part of Matter:

  * NumberOfLogRecordsSupported
  * EnableLogging

  and neither are the following commands:

  * Get Log Record
  * Get Log Record Response

* The NOT feature is "[Zigbee]" in the device library.  Again, events replace it
  in Matter.  That means the following attributes are not part of Matter:

  * KeypadOperationEventMask
  * RemoteOperationEventMask
  * ManualOperationEventMask
  * RFIDOperationEventMask
  * KeypadProgrammingEventMask
  * RemoteProgrammingEventMask
  * RFIDProgrammingEventMask

  and neither are the following commands:

  * Operating Event Notification
  * Programming Event Notification

* The Alarms conformance is Zigbee-only in the device library, so the AlarmMask
  attribute is not part of Matter.

* The USR feature is required in Matter if any of PIN, RID, FPG, FACE are
  supported.  That means anything conditioned on !USR and those features is not
  part of Matter.  Specifically, that is the following commands:

  * Set PIN Code
  * Get PIN Code
  * Get PIN Code Response
  * Clear PIN Code
  * Clear All PIN Codes
  * Set User Status
  * Get User Status
  * Get User Status Response
  * Set User Type
  * Get User Type
  * Get User Type Response
  * Set RFID Code
  * Get RFID Code
  * Get RFID Code Response
  * Clear RFID Code
  * Clear All RFID Codes

Fixes #18492 by
making it clear that these are not part of Matter and hence not to be
tested in Matter certification.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Dec 15, 2023
1 parent c280df4 commit 1075250
Show file tree
Hide file tree
Showing 41 changed files with 417 additions and 12,818 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -989,16 +989,6 @@ server cluster DoorLock = 257 {
kNotSupported = 255;
}

bitmap DlAlarmMask : BITMAP16 {
kLockingMechanismJammed = 0x1;
kLockResetToFactoryDefaults = 0x2;
kReserved = 0x4;
kRFModulePowerCycled = 0x8;
kWrongCodeEntryLimit = 0x10;
kFrontEscutcheonRemovedFromMain = 0x20;
kForcedDoorOpenUnderDoorLockedCondition = 0x40;
}

bitmap DlCredentialRuleMask : BITMAP8 {
kSingle = 0x1;
kDual = 0x2;
Expand Down
Loading

0 comments on commit 1075250

Please sign in to comment.