[YAML] Remove unused list freer (#15415)

* [YAML] Add chip_tests_item_has_list in order to not generate a useless ListFreer if it it not needed * Update generated tests content
project-chip · Jan 23, 2024 · 1678740 · 1678740
1 parent d66e635
commit 1678740
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 3,107 deletions.
diff --git a/examples/chip-tool/templates/tests/partials/test_cluster.zapt b/examples/chip-tool/templates/tests/partials/test_cluster.zapt
@@ -301,7 +301,7 @@ class {{filename}}: public TestCommand
         {{#if isCommand}}
         using RequestType = chip::app::Clusters::{{asUpperCamelCase cluster}}::Commands::{{asUpperCamelCase command}}::Type;
 
-        ListFreer listFreer;
+        {{#if (chip_tests_item_has_list)}} ListFreer listFreer;{{/if}}
         RequestType request;
         {{#chip_tests_item_parameters}}
         {{>commandValue ns=parent.cluster container=(concat "request." (asLowerCamelCase label)) definedValue=definedValue depth=0}}
@@ -335,7 +335,7 @@ class {{filename}}: public TestCommand
         cluster.Associate({{>device}}, endpoint);
         {{/if}}
 
-        ListFreer listFreer;
+        {{#if (chip_tests_item_has_list)}} ListFreer listFreer;{{/if}}
         {{#chip_tests_item_parameters}}
         {{zapTypeToEncodableClusterObjectType type ns=parent.cluster}} {{asLowerCamelCase name}}Argument;
         {{>commandValue ns=parent.cluster container=(concat (asLowerCamelCase name) "Argument") definedValue=definedValue depth=0}}

diff --git a/src/app/zap-templates/common/ClusterTestGeneration.js b/src/app/zap-templates/common/ClusterTestGeneration.js
@@ -768,11 +768,38 @@ function ensureIsArray(value, options)
   }
 }
 
+function chip_tests_item_has_list(options)
+{
+  function hasList(args)
+  {
+    for (let i = 0; i < args.length; i++) {
+      if (args[i].isArray) {
+        return true;
+      }
+
+      if (args[i].isStruct && hasList(args[i].items)) {
+        return true;
+      }
+    }
+
+    return false;
+  }
+
+  return assertCommandOrAttributeOrEvent(this).then(item => {
+    if (this.isWriteAttribute || this.isCommand) {
+      return hasList(item.arguments);
+    }
+
+    return false;
+  });
+}
+
 //
 // Module exports
 //
 exports.chip_tests                          = chip_tests;
 exports.chip_tests_items                    = chip_tests_items;
+exports.chip_tests_item_has_list            = chip_tests_item_has_list;
 exports.chip_tests_item_parameters          = chip_tests_item_parameters;
 exports.chip_tests_item_response_parameters = chip_tests_item_response_parameters;
 exports.chip_tests_pics                     = chip_tests_pics;