Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YAML] Remove unused list freer #15415

Merged

Conversation

vivien-apple
Copy link
Contributor

Problem

ListFreer is declared even if it it never used. That's not a big deal but that's distracting...

Change overview

  • Add an helper to generate it only if needed

@github-actions
Copy link

github-actions bot commented Feb 22, 2022

PR #15415: Size comparison from cbdecce to e7abdf4

Decreases (1 build for linux)
platform target config section cbdecce e7abdf4 change % change
linux chip-tool-ipv6only arm64 (read only) 8864028 8822492 -41536 -0.5
.text 7489236 7447700 -41536 -0.6
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section cbdecce e7abdf4 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598130 598130 0 0.0
.app_xip_area 502968 502968 0 0.0
.bss 77860 77860 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556166 556166 0 0.0
.app_xip_area 462548 462548 0 0.0
.bss 76356 76356 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577402 577402 0 0.0
.app_xip_area 474360 474360 0 0.0
.bss 85452 85452 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915156 915156 0 0.0
(read/write) 128600 128600 0 0.0
.bss 126560 126560 0 0.0
.data 2040 2040 0 0.0
.text 915148 915148 0 0.0
BRD4161A+rpc (read only) 943856 943856 0 0.0
(read/write) 145520 145520 0 0.0
.bss 143336 143336 0 0.0
.data 2180 2180 0 0.0
.text 943848 943848 0 0.0
window-app BRD4161A (read only) 848976 848976 0 0.0
(read/write) 126520 126520 0 0.0
.bss 124608 124608 0 0.0
.data 1908 1908 0 0.0
.text 848968 848968 0 0.0
esp32 all-clusters-app c3devkit (read only) 950796 950796 0 0.0
(read/write) 1399506 1399506 0 0.0
.dram0.bss 66672 66672 0 0.0
.dram0.data 14164 14164 0 0.0
.flash.rodata 199768 199768 0 0.0
.flash.text 950796 950796 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 1000827 1000827 0 0.0
(read/write) 464912 464912 0 0.0
.dram0.bss 71824 71824 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226896 226896 0 0.0
.flash.text 995443 995443 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691092 691092 0 0.0
.bss 77488 77488 0 0.0
.data 1916 1916 0 0.0
.text 605888 605888 0 0.0
lock k32w061+release (read/write) 693636 693636 0 0.0
.bss 77696 77696 0 0.0
.data 1956 1956 0 0.0
.text 608184 608184 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8864028 8822492 -41536 -0.5
(read/write) 434705 434705 0 0.0
.bss 59265 59265 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 319024 319024 0 0.0
.dynamic 560 560 0 0.0
.got 51392 51392 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456468 456468 0 0.0
.text 7489236 7447700 -41536 -0.6
thermostat-no-ble arm64 (read only) 2159644 2159644 0 0.0
(read/write) 149841 149841 0 0.0
.bss 66433 66433 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75216 75216 0 0.0
.dynamic 560 560 0 0.0
.got 4208 4208 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132604 132604 0 0.0
.text 1808352 1808352 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439644 2439644 0 0.0
.bss 194508 194508 0 0.0
.data 5352 5352 0 0.0
.text 1402216 1402216 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2400828 2400828 0 0.0
.bss 188608 188608 0 0.0
.data 5648 5648 0 0.0
.text 1363400 1363400 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2336264 2336264 0 0.0
.bss 187608 187608 0 0.0
.data 5624 5624 0 0.0
.text 1298864 1298864 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2327164 2327164 0 0.0
.bss 186140 186140 0 0.0
.data 5456 5456 0 0.0
.text 1289736 1289736 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1021787 1021787 0 0.0
bss 122624 122624 0 0.0
rodata 120760 120760 0 0.0
text 699492 699492 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 991175 991175 0 0.0
bss 119812 119812 0 0.0
rodata 112284 112284 0 0.0
text 679368 679368 0 0.0
nrf52840dongle_nrf52840 (read/write) 1036607 1036607 0 0.0
bss 123844 123844 0 0.0
rodata 119608 119608 0 0.0
text 703236 703236 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 928510 928510 0 0.0
bss 119184 119184 0 0.0
rodata 114016 114016 0 0.0
text 614520 614520 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 950651 950651 0 0.0
bss 120852 120852 0 0.0
rodata 109600 109600 0 0.0
text 641588 641588 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 858126 858126 0 0.0
bss 117444 117444 0 0.0
rodata 102768 102768 0 0.0
text 557392 557392 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527567 527567 0 0.0
bss 53632 53632 0 0.0
rodata 49948 49948 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 949099 949099 0 0.0
bss 120572 120572 0 0.0
rodata 108552 108552 0 0.0
text 641408 641408 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 945059 945059 0 0.0
bss 120576 120576 0 0.0
rodata 108248 108248 0 0.0
text 637648 637648 0 0.0
shell nrf52840dk_nrf52840 (read/write) 811587 811587 0 0.0
bss 113324 113324 0 0.0
rodata 79752 79752 0 0.0
text 540852 540852 0 0.0
p6 all-clusters-app default (read/write) 2489568 2489568 0 0.0
.bss 122400 122400 0 0.0
.data 2680 2680 0 0.0
.text 1447832 1447832 0 0.0
light-app default (read/write) 2393560 2393560 0 0.0
.bss 113648 113648 0 0.0
.data 2528 2528 0 0.0
.text 1351824 1351824 0 0.0
lock-app default (read/write) 2357120 2357120 0 0.0
.bss 113400 113400 0 0.0
.data 2488 2488 0 0.0
.text 1315384 1315384 0 0.0
qpg lighting-app qpg6105+debug (read only) 599972 599972 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90904 90904 0 0.0
.data 1116 1116 0 0.0
.text 594652 594652 0 0.0
lock-app qpg6105+debug (read only) 565732 565732 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90912 90912 0 0.0
.data 1068 1068 0 0.0
.text 560412 560412 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 880954 880954 0 0.0
bss 86372 86372 0 0.0
noinit 37160 37160 0 0.0
text 622274 622274 0 0.0

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want the same in some of the Darwin code, as a followup.

@bzbarsky-apple bzbarsky-apple merged commit 466de2e into project-chip:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants