-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix incorrect suppression of compiler errors in cirque tests. (#3317)
ninja sends all output, including compiler errors, to stdout, not stderr. So redirecting to /dev/null was hiding compiler errors and making it very difficult to debug test failures.
- Loading branch information
1 parent
602cc76
commit 9cd693d
Showing
2 changed files
with
14 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
#!/usr/bin/env bash | ||
|
||
# This function is a workaround for the fact that ninja sends all | ||
# output, including compiler errors, to stdout, not stderr. We want | ||
# to suppress the various output from ninja itself, but not compiler | ||
# errors. Do that by prefixing the ninja output with a string that is | ||
# unlikely to appear in compiler errors, then filtering it out. | ||
function run_ninja() { | ||
prefix="|ninja_filter_prefix|" | ||
NINJA_STATUS="$prefix[%f/%t] " ninja "$@" | grep -v "^$prefix" | ||
} |