Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nRF5 platform makefile is not building all source code #113

Closed
pan-apple opened this issue Mar 25, 2020 · 2 comments
Closed

nRF5 platform makefile is not building all source code #113

pan-apple opened this issue Mar 25, 2020 · 2 comments
Assignees
@bukepo
Labels
feature work
Milestone
June 26, 2020

Comments

@pan-apple
Copy link
Contributor

Problem

The following files are not being built, as they are heavily dependent on removed code (as part of #104 )

ConfigurationManagerImpl.cpp
ThreadStackManagerImpl.cpp
GroupKeyStoreImpl.cpp
SoftwareUpdateManagerImpl.cpp
Entropy.cpp

Removed from src/platform/Makefile.am

Proposed Solution

Fix the code, and add to makefile.
@rwalker-apple rwalker-apple added this to the M3 milestone Mar 25, 2020
@sagar-apple sagar-apple mentioned this issue Apr 7, 2020
Closed
6 tasks
@woody-apple woody-apple modified the milestones: M3, June 26, 2020 Jun 10, 2020
@woody-apple
Copy link
Contributor

@bukepo Would you be able to take a look at this, given you seem to be working on this platform right now?

@bukepo
Copy link
Contributor

bukepo commented Sep 30, 2020

ConfigurationManagerImpl.cpp was fixed by 9267c5b.

Thread stack is already built and up.

Group key store, Entropy and SoftwareUpdateManager seems not used on any platform.

I don't think this is a blocking issue for project nRF5 platform.

@bukepo bukepo closed this as completed Sep 30, 2020
andy31415 pushed a commit that referenced this issue Apr 24, 2023
@tehampson @jmartinez-silabs
Bump third_party/pigweed/repo from 73cac22 to b88cd71 (#26133)
6025455 
* Pin new pigweed branch

* Fix issues caught in CI

* Fix CI

* Clean up

* Fix QPG plaform CI issues

* Fix CI issues for Ameba

* Fix Ameba CI for real this time

* Restyle

* Fix k32w0 and mw320 CI

* Restyle

* CI fixes for TI platform stuff

* Fixes CI for Infineon

* Fix/efr32 ci with pw roll up (#113)

* add syscall_stubs to efr32 test driver to support gcc 12

* fix release pw rpc build, and test driver

* Fix CI for Infineon cyw30739

* Roll to latest pigweed commit

* Clean up for review

* Fix CI

* Restyle

* Fix CI

---------

Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bukepo bukepo

Labels
feature work
Projects
None yet
Milestone
June 26, 2020
Development

No branches or pull requests
4 participants
@bukepo @woody-apple @pan-apple @rwalker-apple