Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] Mark MTRDeviceController as not running before we shut down the cpp commissioner #22488

Closed
bzbarsky-apple opened this issue Sep 8, 2022 · 0 comments · Fixed by #22490

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Sep 8, 2022

Reproduction steps

Right now in MTRDeviceConroller shutdown we do the cpp commissioner shutdown and then mark ourselves as "not running". If commissioner shutdown leads to callbacks (which it can, as things get notified as timed out), a caller could try to make calls on us that we would forward on to the Matter stack while it's in a not-very-consistent state.

Platform

darwin

Platform Version(s)

No response

Type

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

Found by code inspection.

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant