Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark MTRDeviceController as not running before shutting down the DeviceCommissioner. #22490

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Mark MTRDeviceController as not running before shutting down the DeviceCommissioner. #22490

merged 1 commit into from
Sep 9, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Sep 8, 2022 •
edited
Loading

Fixes #22488

Change overview

Set member to null before calling Shutdown on the object, not after.

@github-actions github-actions bot added the darwin label Sep 8, 2022
@github-actions
Copy link

github-actions bot commented Sep 8, 2022 •
edited
Loading

PR #22490: Size comparison from 0e3bbae to 9f77733

Increases above 0.2%:

platform target config section 0e3bbae 9f77733 change % change
psoc6 all-clusters cy8ckit_062s2_43012 .debug_ranges 338400 340304 1904 0.6
all-clusters-minimal cy8ckit_062s2_43012 .debug_ranges 337016 338920 1904 0.6
light cy8ckit_062s2_43012 .debug_ranges 302488 304392 1904 0.6
lock cy8ckit_062s2_43012 .debug_ranges 305832 307736 1904 0.6
Increases (33 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 0e3bbae 9f77733 change % change
bl602 lighting-app bl602 (read/write) 1410290 1411750 1460 0.1
.text 1065690 1066992 1302 0.1
bl602+rpc (read/write) 1455486 1457210 1724 0.1
.text 1097038 1098598 1560 0.1
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675431 676127 696 0.1
.rodata 89223 89383 160 0.2
.text 585896 586432 536 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 640151 640847 696 0.1
.rodata 78375 78535 160 0.2
.text 561456 561992 536 0.1
lock-ftd LP_CC2652R7 (read only) 676483 677195 712 0.1
.rodata 77075 77235 160 0.2
.text 598928 599480 552 0.1
lock-mtd LP_CC2652R7 (read only) 659483 660187 704 0.1
.rodata 102355 102515 160 0.2
.text 556648 557192 544 0.1
pump-app LP_CC2652R7 (read only) 685343 686039 696 0.1
.rodata 90103 90263 160 0.2
.text 594756 595292 536 0.1
pump-controller-app LP_CC2652R7 (read only) 669835 670531 696 0.1
.rodata 85659 85819 160 0.2
.text 583696 584232 536 0.1
shell LP_CC2652R7 (read only) 666090 666794 704 0.1
.rodata 85778 85938 160 0.2
.text 579996 580540 544 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 587002 587394 392 0.1
.app_xip_area 463660 464052 392 0.1
lock cyw930739m2evb_01 (read/write) 592738 593146 408 0.1
.app_xip_area 464612 465020 408 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599914 600618 704 0.1
.app_xip_area 477292 477996 704 0.1
efr32 lighting-app BRD4161A (read/write) 1108624 1109944 1320 0.1
.text 970200 971520 1320 0.1
BRD4161A+rpc (read/write) 972316 973020 704 0.1
.text 819200 819904 704 0.1
BRD4161A+rs911x (read/write) 1002056 1003384 1328 0.1
.text 830804 832132 1328 0.2
lock-app BRD4161A+wf200 (read/write) 1150180 1150884 704 0.1
.text 995840 996544 704 0.1
window-app BRD4161A (read/write) 1099856 1101176 1320 0.1
.text 959968 961288 1320 0.1
esp32 all-clusters-app c3devkit (read only) 1033930 1034618 688 0.1
(read/write) 1493566 1493734 168 0.0
.flash.rodata 218080 218248 168 0.1
.flash.text 1033930 1034618 688 0.1
m5stack (read only) 1086511 1087167 656 0.1
(read/write) 490852 491012 160 0.0
.flash.rodata 247392 247552 160 0.1
.flash.text 1081127 1081783 656 0.1
k32w light k32w0+release (read/write) 648268 648828 560 0.1
.text 572760 573320 560 0.1
lock k32w0+release (read/write) 705312 706016 704 0.1
.text 629348 630052 704 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2455136 2455224 88 0.0
.text 1417780 1417868 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181327 1182027 700 0.1
rodata 143584 143740 156 0.1
text 815164 815708 544 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160507 1161227 720 0.1
1160507 1160523 16 0.0
rodata 135172 135332 160 0.1
text 803552 804100 548 0.1
803552 803556 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1742572 1743908 1336 0.1
.debug_abbrev 1221650 1221907 257 0.0
.debug_aranges 111744 111776 32 0.0
.debug_frame 373048 373168 120 0.0
.debug_info 26719024 26738028 19004 0.1
.debug_line 3658002 3662561 4559 0.1
.debug_loc 3573942 3580890 6948 0.2
.debug_ranges 338400 340304 1904 0.6
.debug_str 3427580 3428044 464 0.0
.strtab 570615 570955 340 0.1
.symtab 421488 421680 192 0.0
.text 1542800 1544136 1336 0.1
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1685772 1687092 1320 0.1
.debug_abbrev 1213489 1213746 257 0.0
.debug_aranges 111216 111248 32 0.0
.debug_frame 376128 376248 120 0.0
.debug_info 26455647 26474652 19005 0.1
.debug_line 3678518 3683101 4583 0.1
.debug_loc 3561579 3568527 6948 0.2
.debug_ranges 337016 338920 1904 0.6
.debug_str 3416585 3417049 464 0.0
.strtab 535089 535429 340 0.1
.symtab 408080 408272 192 0.0
.text 1486736 1488056 1320 0.1
light cy8ckit_062s2_43012 (read/write) 1603028 1604340 1312 0.1
.debug_abbrev 1048308 1048565 257 0.0
.debug_aranges 103392 103424 32 0.0
.debug_frame 346396 346516 120 0.0
.debug_info 21917818 21936823 19005 0.1
.debug_line 3248983 3253530 4547 0.1
.debug_loc 3259921 3266821 6900 0.2
.debug_ranges 302488 304392 1904 0.6
.debug_str 3221851 3222315 464 0.0
.strtab 468388 468728 340 0.1
.symtab 375168 375360 192 0.1
.text 1412224 1413536 1312 0.1
lock cy8ckit_062s2_43012 (read/write) 1640716 1642028 1312 0.1
.debug_abbrev 1055743 1056000 257 0.0
.debug_aranges 104064 104096 32 0.0
.debug_frame 349224 349344 120 0.0
.debug_info 22297601 22316606 19005 0.1
22297601 22297602 1 0.0
.debug_line 3257804 3262339 4535 0.1
.debug_loc 3299773 3306688 6915 0.2
.debug_ranges 305832 307736 1904 0.6
.debug_str 3249272 3249736 464 0.0
.strtab 474591 474931 340 0.1
.symtab 378352 378544 192 0.1
.text 1444880 1446192 1312 0.1
qpg lighting-app qpg6105+debug (read/write) 1129284 1129980 696 0.1
.text 576380 577076 696 0.1
lock-app qpg6105+debug (read/write) 1100264 1100976 712 0.1
.text 547364 548076 712 0.1
telink light-switch-app tlsr9518adk80d (read/write) 812168 812960 792 0.1
text 573712 574348 636 0.1
lighting-app tlsr9518adk80d (read/write) 834072 834872 800 0.1
text 591838 592478 640 0.1
591838 591840 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 842324 843116 792 0.1
text 598106 598738 632 0.1
Decreases (12 builds for bl602, cc13x2_26x2, psoc6, telink)
platform target config section 0e3bbae 9f77733 change % change
bl602 lighting-app bl602+rpc .text 1097038 1097036 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 175976 175280 -696 -0.4
lock-ftd LP_CC2652R7 (read/write) 165236 164524 -712 -0.4
lock-mtd LP_CC2652R7 (read/write) 177924 177220 -704 -0.4
pump-app LP_CC2652R7 (read/write) 157080 156384 -696 -0.4
pump-controller-app LP_CC2652R7 (read/write) 172700 172004 -696 -0.4
shell LP_CC2652R7 (read/write) 180836 180132 -704 -0.4
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26719024 26719023 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26455647 26455646 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 21917818 21917816 -2 -0.0
telink light-switch-app tlsr9518adk80d text 573712 573710 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 842324 842316 -8 -0.0
text 598106 598102 -4 -0.0
Full report (46 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 0e3bbae 9f77733 change % change
bl602 lighting-app bl602 (read/write) 1410290 1411750 1460 0.1
1410290 1410290 0 0.0
.bss 121585 121585 0 0.0
.data 9816 9816 0 0.0
.text 1065690 1066992 1302 0.1
1065690 1065690 0 0.0
bl602+rpc (read/write) 1455486 1457210 1724 0.1
1455486 1455486 0 0.0
.bss 129017 129017 0 0.0
.data 10200 10200 0 0.0
.text 1097038 1098598 1560 0.1
1097038 1097036 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675431 676127 696 0.1
675431 675431 0 0.0
(read/write) 175976 175280 -696 -0.4
175976 175976 0 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89223 89383 160 0.2
89223 89223 0 0.0
.text 585896 586432 536 0.1
585896 585896 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640151 640847 696 0.1
640151 640151 0 0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78375 78535 160 0.2
78375 78375 0 0.0
.text 561456 561992 536 0.1
561456 561456 0 0.0
lock-ftd LP_CC2652R7 (read only) 676483 677195 712 0.1
676483 676483 0 0.0
(read/write) 165236 164524 -712 -0.4
165236 165236 0 0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77075 77235 160 0.2
77075 77075 0 0.0
.text 598928 599480 552 0.1
598928 598928 0 0.0
lock-mtd LP_CC2652R7 (read only) 659483 660187 704 0.1
659483 659483 0 0.0
(read/write) 177924 177220 -704 -0.4
177924 177924 0 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102355 102515 160 0.2
102355 102355 0 0.0
.text 556648 557192 544 0.1
556648 556648 0 0.0
pump-app LP_CC2652R7 (read only) 685343 686039 696 0.1
685343 685343 0 0.0
(read/write) 157080 156384 -696 -0.4
157080 157080 0 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 90103 90263 160 0.2
90103 90103 0 0.0
.text 594756 595292 536 0.1
594756 594756 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669835 670531 696 0.1
669835 669835 0 0.0
(read/write) 172700 172004 -696 -0.4
172700 172700 0 0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85659 85819 160 0.2
85659 85659 0 0.0
.text 583696 584232 536 0.1
583696 583696 0 0.0
shell LP_CC2652R7 (read only) 666090 666794 704 0.1
666090 666090 0 0.0
(read/write) 180836 180132 -704 -0.4
180836 180836 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85778 85938 160 0.2
85778 85778 0 0.0
.text 579996 580540 544 0.1
579996 579996 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587002 587394 392 0.1
587002 587002 0 0.0
.app_xip_area 463660 464052 392 0.1
463660 463660 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592738 593146 408 0.1
592738 592738 0 0.0
.app_xip_area 464612 465020 408 0.1
464612 464612 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599914 600618 704 0.1
599914 599914 0 0.0
.app_xip_area 477292 477996 704 0.1
477292 477292 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1108624 1109944 1320 0.1
1108624 1108624 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 970200 971520 1320 0.1
970200 970200 0 0.0
BRD4161A+rpc (read/write) 972316 973020 704 0.1
972316 972316 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 819200 819904 704 0.1
819200 819200 0 0.0
BRD4161A+rs911x (read/write) 1002056 1003384 1328 0.1
1002056 1002056 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 830804 832132 1328 0.2
830804 830804 0 0.0
lock-app BRD4161A+wf200 (read/write) 1150180 1150884 704 0.1
1150180 1150180 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 995840 996544 704 0.1
995840 995840 0 0.0
window-app BRD4161A (read/write) 1099856 1101176 1320 0.1
1099856 1099856 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 959968 961288 1320 0.1
959968 959968 0 0.0
esp32 all-clusters-app c3devkit (read only) 1033930 1034618 688 0.1
1033930 1033930 0 0.0
(read/write) 1493566 1493734 168 0.0
1493566 1493566 0 0.0
.dram0.bss 71120 71120 0 0.0
.dram0.data 13696 13696 0 0.0
.flash.rodata 218080 218248 168 0.1
218080 218080 0 0.0
.flash.text 1033930 1034618 688 0.1
1033930 1033930 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1086511 1087167 656 0.1
1086511 1086511 0 0.0
(read/write) 490852 491012 160 0.0
490852 490852 0 0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 247392 247552 160 0.1
247392 247392 0 0.0
.flash.text 1081127 1081783 656 0.1
1081127 1081127 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 648268 648828 560 0.1
648268 648268 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 572760 573320 560 0.1
572760 572760 0 0.0
lock k32w0+release (read/write) 705312 706016 704 0.1
705312 705312 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 629348 630052 704 0.1
629348 629348 0 0.0
linux all-clusters-app debug (read only) 3046569 3046569 0 0.0
(read/write) 156064 156064 0 0.0
.bss 61824 61824 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85768 85768 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 275691 275691 0 0.0
.text 2591442 2591442 0 0.0
all-clusters-minimal-app debug (read only) 2882433 2882433 0 0.0
(read/write) 147664 147664 0 0.0
.bss 61056 61056 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78264 78264 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 275915 275915 0 0.0
.text 2429858 2429858 0 0.0
bridge-app debug+rpc (read only) 2380169 2380169 0 0.0
(read/write) 127752 127752 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67640 67640 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 204552 204552 0 0.0
.text 2012706 2012706 0 0.0
chip-tool debug (read only) 10958017 10958017 0 0.0
(read/write) 657736 657736 0 0.0
.bss 26072 26072 0 0.0
.data 2690 2690 0 0.0
.data.rel.ro 622456 622456 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 570325 570325 0 0.0
.text 8866468 8866468 0 0.0
chip-tool-ipv6only arm64 (read only) 10330188 10330188 0 0.0
(read/write) 705601 705601 0 0.0
.bss 33937 33937 0 0.0
.data 2856 2856 0 0.0
.data.rel.ro 649976 649976 0 0.0
.dynamic 560 560 0 0.0
.got 13864 13864 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 499948 499948 0 0.0
.text 8177220 8177220 0 0.0
lighting-app debug+rpc (read only) 2605593 2605593 0 0.0
(read/write) 130536 130536 0 0.0
.bss 49792 49792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72680 72680 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221392 221392 0 0.0
.text 2213010 2213010 0 0.0
lock-app debug (read only) 2588577 2588577 0 0.0
(read/write) 125712 125712 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69688 69688 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 238384 238384 0 0.0
.text 2183250 2183250 0 0.0
ota-provider-app debug (read only) 2365833 2365833 0 0.0
(read/write) 119144 119144 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63512 63512 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 210360 210360 0 0.0
.text 1991714 1991714 0 0.0
ota-requestor-app debug (read only) 2531161 2531161 0 0.0
(read/write) 127552 127552 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68920 68920 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 217184 217184 0 0.0
.text 2141074 2141074 0 0.0
shell debug (read only) 2614905 2614905 0 0.0
(read/write) 142184 142184 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77376 77376 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 235826 235826 0 0.0
.text 2220370 2220370 0 0.0
thermostat-no-ble arm64 (read only) 2364244 2364244 0 0.0
(read/write) 141857 141857 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76112 76112 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141356 141356 0 0.0
.text 1984848 1984848 0 0.0
tv-app debug (read only) 3198785 3198785 0 0.0
(read/write) 258392 258392 0 0.0
.bss 168152 168152 0 0.0
.data 4144 4144 0 0.0
.data.rel.ro 79520 79520 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 260616 260616 0 0.0
.text 2747778 2747778 0 0.0
tv-casting-app debug (read only) 5516377 5516377 0 0.0
(read/write) 160888 160888 0 0.0
.bss 52120 52120 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 100488 100488 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 346001 346001 0 0.0
.text 4898066 4898066 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455136 2455224 88 0.0
2455136 2455136 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417780 1417868 88 0.0
1417780 1417780 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181327 1182027 700 0.1
1181327 1181327 0 0.0
bss 143641 143641 0 0.0
rodata 143584 143740 156 0.1
143584 143584 0 0.0
text 815164 815708 544 0.1
815164 815164 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160507 1161227 720 0.1
1160507 1160523 16 0.0
bss 142868 142868 0 0.0
rodata 135172 135332 160 0.1
135172 135172 0 0.0
text 803552 804100 548 0.1
803552 803556 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1742572 1743908 1336 0.1
1742572 1742572 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221650 1221907 257 0.0
1221650 1221650 0 0.0
.debug_aranges 111744 111776 32 0.0
111744 111744 0 0.0
.debug_frame 373048 373168 120 0.0
373048 373048 0 0.0
.debug_info 26719024 26738028 19004 0.1
26719024 26719023 -1 -0.0
.debug_line 3658002 3662561 4559 0.1
3658002 3658002 0 0.0
.debug_loc 3573942 3580890 6948 0.2
3573942 3573942 0 0.0
.debug_ranges 338400 340304 1904 0.6
338400 338400 0 0.0
.debug_str 3427580 3428044 464 0.0
3427580 3427580 0 0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570615 570955 340 0.1
570615 570615 0 0.0
.symtab 421488 421680 192 0.0
421488 421488 0 0.0
.text 1542800 1544136 1336 0.1
0 0 0 0.0
1542800 1542800 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1685772 1687092 1320 0.1
1685772 1685772 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213489 1213746 257 0.0
1213489 1213489 0 0.0
.debug_aranges 111216 111248 32 0.0
111216 111216 0 0.0
.debug_frame 376128 376248 120 0.0
376128 376128 0 0.0
.debug_info 26455647 26474652 19005 0.1
26455647 26455646 -1 -0.0
.debug_line 3678518 3683101 4583 0.1
3678518 3678518 0 0.0
.debug_loc 3561579 3568527 6948 0.2
3561579 3561579 0 0.0
.debug_ranges 337016 338920 1904 0.6
337016 337016 0 0.0
.debug_str 3416585 3417049 464 0.0
3416585 3416585 0 0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535089 535429 340 0.1
535089 535089 0 0.0
.symtab 408080 408272 192 0.0
408080 408080 0 0.0
.text 1486736 1488056 1320 0.1
1486736 1486736 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1603028 1604340 1312 0.1
1603028 1603028 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1048308 1048565 257 0.0
1048308 1048308 0 0.0
.debug_aranges 103392 103424 32 0.0
103392 103392 0 0.0
.debug_frame 346396 346516 120 0.0
346396 346396 0 0.0
.debug_info 21917818 21936823 19005 0.1
21917818 21917816 -2 -0.0
.debug_line 3248983 3253530 4547 0.1
3248983 3248983 0 0.0
.debug_loc 3259921 3266821 6900 0.2
3259921 3259921 0 0.0
.debug_ranges 302488 304392 1904 0.6
302488 302488 0 0.0
.debug_str 3221851 3222315 464 0.0
3221851 3221851 0 0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468388 468728 340 0.1
468388 468388 0 0.0
.symtab 375168 375360 192 0.1
375168 375168 0 0.0
.text 1412224 1413536 1312 0.1
1412224 1412224 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640716 1642028 1312 0.1
1640716 1640716 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1055743 1056000 257 0.0
1055743 1055743 0 0.0
.debug_aranges 104064 104096 32 0.0
104064 104064 0 0.0
.debug_frame 349224 349344 120 0.0
349224 349224 0 0.0
.debug_info 22297601 22316606 19005 0.1
22297601 22297602 1 0.0
.debug_line 3257804 3262339 4535 0.1
3257804 3257804 0 0.0
.debug_loc 3299773 3306688 6915 0.2
3299773 3299773 0 0.0
.debug_ranges 305832 307736 1904 0.6
305832 305832 0 0.0
.debug_str 3249272 3249736 464 0.0
3249272 3249272 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474591 474931 340 0.1
474591 474591 0 0.0
.symtab 378352 378544 192 0.1
378352 378352 0 0.0
.text 1444880 1446192 1312 0.1
1444880 1444880 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1129284 1129980 696 0.1
1129284 1129284 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 576380 577076 696 0.1
576380 576380 0 0.0
lock-app qpg6105+debug (read/write) 1100264 1100976 712 0.1
1100264 1100264 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 547364 548076 712 0.1
547364 547364 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 812168 812960 792 0.1
812168 812168 0 0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 573712 574348 636 0.1
573712 573710 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 834072 834872 800 0.1
834072 834072 0 0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 591838 592478 640 0.1
591838 591840 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 842324 843116 792 0.1
842324 842316 -8 -0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 598106 598738 632 0.1
598106 598102 -4 -0.0

@bzbarsky-apple bzbarsky-apple reopened this Sep 8, 2022
@andy31415 andy31415 merged commit 7a45a4b into project-chip:master Sep 9, 2022
@bzbarsky-apple bzbarsky-apple deleted the null-out-commissioner-earlier branch September 10, 2022 04:52
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@bzbarsky-apple @isiu-apple
Mark MTRDeviceController as not running before shutting down the Devi…
f51370a 
…ceCommissioner. (project-chip#22490)

Fixes project-chip#22488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@vivien-apple vivien-apple vivien-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
darwin platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Platform] Mark MTRDeviceController as not running before we shut down the cpp commissioner
4 participants
@bzbarsky-apple @yunhanw-google @vivien-apple @andy31415