Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Once our enums are sized properly, or once we stop depending on the #7622

Closed
todo bot opened this issue Jun 14, 2021 · 0 comments · Fixed by #7841
Closed

Once our enums are sized properly, or once we stop depending on the #7622

todo bot opened this issue Jun 14, 2021 · 0 comments · Fixed by #7841
Assignees
Labels

Comments

@todo
Copy link

todo bot commented Jun 14, 2021

// TODO: Once our enums are sized properly, or once we stop depending on the
// value being a certain type, we can remove the static_cast. For now the
// cast is safe because all EmberAfKeypadInputStatus values fit in uint32_t.
emberAfFillExternalBuffer((ZCL_CLUSTER_SPECIFIC_COMMAND | ZCL_FRAME_CONTROL_SERVER_TO_CLIENT), ZCL_KEYPAD_INPUT_CLUSTER_ID,
ZCL_SEND_KEY_RESPONSE_COMMAND_ID, "u", static_cast<uint8_t>(keypadInputStatus));
EmberStatus status = emberAfSendResponse();
if (status != EMBER_SUCCESS)


This issue was generated by todo based on a TODO comment in 18597e0 when #7607 was merged. cc @bzbarsky-apple.
@todo todo bot added the todo label Jun 14, 2021
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 23, 2021
woody-apple pushed a commit that referenced this issue Jun 23, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this issue Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant