-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TestTcp retry TCP initialization #15824
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpschoedel
approved these changes
Mar 3, 2022
tcarmelveilleux
approved these changes
Mar 3, 2022
PR #15824: Size comparison from 3b83461 to 7686f0c Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TestTCP is flaky, seemingly because of a "Address already in use" error. See https://github.com/project-chip/connectedhomeip/runs/5407037210?check_suite_focus=true or
https://github.com/project-chip/connectedhomeip/runs/5408995357?check_suite_focus=true
Change overview
Retry init a few times (5 seconds max) with a lengthy comment of what I think is happening and what a "followup fix" should contain.
Testing
Ran this 100s of times on a mac mini. Without the fix reproduced the crash, with the fix observed a 'retrying' message and test passed.