[EFR32] Implement methods for NotifyUpdateApplied after an OTA update #18584

selissia · 2022-05-18T23:15:53Z

Problem

EFR32 platform needs to transmit a NotifyUpdateApplied after a successful software update

Change overview

Implement IsFirstImageRun() and ConfirmCurrentImage() in the EFR32 implementation of OTAImageProcessor. This allows the DefaultOTARequestor object to execute the logic that triggers a NotifyUpdateApplied() call.
Introduce EFR32_KVS_SAVE_DELAY_SECONDS to represent the delay amount KeyValueStoreManagerImpl uses before saving the key/vaule pair
Delay HandleApply() to give KVS time to store the data in StoreCurrentUpdateInfo()
(Unrelated to the NotifyUpdateApplied issue) Define ApplicationCertificate_t structure to carry the boot image certificate

Testing

Verified that NotifyUpdateApplied() is triggered after an OTA update and reboot

* Added new manual scripts * Added Auto generated File

* [ota] Store Default OTA Providers in flash Store Default OTA Providers in flash each time the attribute is modified and load it back on the application startup. * Restyled by clang-format * Fix build and reduce flash usage Co-authored-by: Restyled.io <commits@restyled.io>

Delay HandleApply() to give KVS time to store the data in StoreCurrentUpdateInfo(). Introduce EFR32_KVS_SAVE_DELAY_SECONDS to represent the delay amount KeyValueStoreManagerImpl uses before saving the key/vaule pair

github-actions · 2022-05-18T23:46:34Z

PR #18584: Size comparison from 927afdf to e312dcd

Full report (14 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)

platform	target	config	section	`927afdf`	`e312dcd`
cyw30739	light	cyw930739m2evb_01	(read/write)	625490	625490
			.app_xip_area	529104	529104
			.bss	79028	79028
			.data	708	708
			.rodata	0	0
			.text	0	0
	lock	cyw930739m2evb_01	(read/write)	628454	628454
			.app_xip_area	533524	533524
			.bss	77604	77604
			.data	672	672
			.rodata	0	0
			.text	0	0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	572886	572886
			.app_xip_area	468240	468240
			.bss	87024	87024
			.data	584	584
			.rodata	0	0
			.text	112	112
k32w	light	k32w061+release	(read/write)	683000	683000
			.bss	80224	80224
			.data	2016	2016
			.text	599056	599056
	lock	k32w061+release	(read/write)	729520	729520
			.bss	80656	80656
			.data	1976	1976
			.text	645184	645184
linux	chip-tool-no-interactive-ipv6only	arm64	(read only)	`9078148`	`9078148`
			(read/write)	646209	646209
			.bss	42209	42209
			.data	1192	1192
			.data.rel.ro	583944	583944
			.dynamic	560	560
			.got	15016	15016
			.init	24	24
			.init_array	184	184
			.rodata	444948	444948
			.text	7168996	7168996
	thermostat-no-ble	arm64	(read only)	2352748	2352748
			(read/write)	176289	176289
			.bss	87585	87585
			.data	1520	1520
			.data.rel.ro	79376	79376
			.dynamic	560	560
			.got	4768	4768
			.init	24	24
			.init_array	376	376
			.rodata	147148	147148
			.text	1975616	1975616
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2420632	2420632
			.bss	202668	202668
			.data	5872	5872
			.text	1383276	1383276
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	`1181007`	`1181007`
			bss	138380	138380
			rodata	153080	153080
			text	810672	810672
p6	all-clusters-app	default	(read/write)	2539008	2539008
			.bss	136176	136176
			.data	2808	2808
			.text	1497272	1497272
	light-app	default	(read/write)	2425416	2425416
			.bss	129488	129488
			.data	2608	2608
			.text	1383680	1383680
	lock-app	default	(read/write)	2436136	2436136
			.bss	129304	129304
			.data	2568	2568
			.text	1394400	1394400
telink	light-switch-app	tlsr9518adk80d	(read/write)	782668	782668
			bss	70608	70608
			noinit	40416	40416
			text	553480	553480
	lighting-app	tlsr9518adk80d	(read/write)	802760	802760
			bss	70864	70864
			noinit	40416	40416
			text	570246	570246

…abs-image-applied

github-actions · 2022-05-19T00:34:15Z

PR #18584: Size comparison from 927afdf to cd3e78b

Increases (5 builds for efr32)

platform	target	config	section	`927afdf`	cd3e78b4	change
efr32	lighting-app	BRD4161A	(read only)	917604	917940	336
			.text	917596	917932	336
		BRD4161A+rpc	(read only)	951776	952112	336
			.text	951768	952104	336
		BRD4161A+rs911x	(read only)	791044	791380	336
			.text	791036	791372	336
	lock-app	BRD4161A+wf200	(read only)	946996	947332	336
			.text	946988	947324	336
	window-app	BRD4161A	(read only)	897708	898044	336
			.text	897700	898036	336

Full report (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)

platform	target	config	section	`927afdf`	cd3e78b4	change
cyw30739	light	cyw930739m2evb_01	(read/write)	625490	625490	0
			.app_xip_area	529104	529104	0
			.bss	79028	79028	0
			.data	708	708	0
			.rodata	0	0	0
			.text	0	0	0
	lock	cyw930739m2evb_01	(read/write)	628454	628454	0
			.app_xip_area	533524	533524	0
			.bss	77604	77604	0
			.data	672	672	0
			.rodata	0	0	0
			.text	0	0	0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	572886	572886	0
			.app_xip_area	468240	468240	0
			.bss	87024	87024	0
			.data	584	584	0
			.rodata	0	0	0
			.text	112	112	0
efr32	lighting-app	BRD4161A	(read only)	917604	917940	336
			(read/write)	133244	133244	0
			.bss	131184	131184	0
			.data	2060	2060	0
			.text	917596	917932	336
		BRD4161A+rpc	(read only)	951776	952112	336
			(read/write)	149928	149928	0
			.bss	147664	147664	0
			.data	2264	2264	0
			.text	951768	952104	336
		BRD4161A+rs911x	(read only)	791044	791380	336
			(read/write)	129512	129512	0
			.bss	127444	127444	0
			.data	2068	2068	0
			.text	791036	791372	336
	lock-app	BRD4161A+wf200	(read only)	946996	947332	336
			(read/write)	123996	123996	0
			.bss	121972	121972	0
			.data	2024	2024	0
			.text	946988	947324	336
	window-app	BRD4161A	(read only)	897708	898044	336
			(read/write)	133304	133304	0
			.bss	131256	131256	0
			.data	2048	2048	0
			.text	897700	898036	336
esp32	all-clusters-app	c3devkit	(read only)	`1000886`	`1000886`	0
			(read/write)	`1478122`	`1478122`	0
			.dram0.bss	68208	68208	0
			.dram0.data	14624	14624	0
			.flash.rodata	209864	209864	0
			.flash.text	`1000886`	`1000886`	0
			.iram0.text	62954	62954	0
		m5stack	(read only)	1056023	1056023	0
			(read/write)	480124	480124	0
			.dram0.bss	73728	73728	0
			.dram0.data	34200	34200	0
			.flash.rodata	240200	240200	0
			.flash.text	1050639	1050639	0
			.iram0.text	123267	123267	0
k32w	light	k32w061+release	(read/write)	683000	683000	0
			.bss	80224	80224	0
			.data	2016	2016	0
			.text	599056	599056	0
	lock	k32w061+release	(read/write)	729520	729520	0
			.bss	80656	80656	0
			.data	1976	1976	0
			.text	645184	645184	0
linux	chip-tool-no-interactive-ipv6only	arm64	(read only)	`9078148`	`9078148`	0
			(read/write)	646209	646209	0
			.bss	42209	42209	0
			.data	1192	1192	0
			.data.rel.ro	583944	583944	0
			.dynamic	560	560	0
			.got	15016	15016	0
			.init	24	24	0
			.init_array	184	184	0
			.rodata	444948	444948	0
			.text	7168996	7168996	0
	thermostat-no-ble	arm64	(read only)	2352748	2352748	0
			(read/write)	176289	176289	0
			.bss	87585	87585	0
			.data	1520	1520	0
			.data.rel.ro	79376	79376	0
			.dynamic	560	560	0
			.got	4768	4768	0
			.init	24	24	0
			.init_array	376	376	0
			.rodata	147148	147148	0
			.text	1975616	1975616	0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	2420632	2420632	0
			.bss	202668	202668	0
			.data	5872	5872	0
			.text	1383276	1383276	0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	`1181007`	`1181007`	0
			bss	138380	138380	0
			rodata	153080	153080	0
			text	810672	810672	0
p6	all-clusters-app	default	(read/write)	2539008	2539008	0
			.bss	136176	136176	0
			.data	2808	2808	0
			.text	1497272	1497272	0
	light-app	default	(read/write)	2425416	2425416	0
			.bss	129488	129488	0
			.data	2608	2608	0
			.text	1383680	1383680	0
	lock-app	default	(read/write)	2436136	2436136	0
			.bss	129304	129304	0
			.data	2568	2568	0
			.text	1394400	1394400	0
telink	light-switch-app	tlsr9518adk80d	(read/write)	782668	782668	0
			bss	70608	70608	0
			noinit	40416	40416	0
			text	553480	553480	0
	lighting-app	tlsr9518adk80d	(read/write)	802760	802760	0
			bss	70864	70864	0
			noinit	40416	40416	0
			text	570246	570246	0

kowsisoundhar12 and others added 26 commits March 8, 2022 22:28

Test added march 8 (project-chip#15957)

35fad7d

* Added new manual scripts * Added Auto generated File

[OTA] Fix OTARequestorDriverImpl inclusion (project-chip#15981)

d5f4b0b

Regen to fix CI failures (project-chip#15990)

9bee828

Merge branch 'master' of github.com:project-chip/connectedhomeip

c219807

Merge branch 'project-chip:master' into master

fa279bc

Merge branch 'project-chip:master' into master

9e18f9b

Merge branch 'project-chip:master' into master

b6ca5ca

Merge branch 'project-chip:master' into master

135dc25

Merge branch 'project-chip:master' into master

0446c67

Merge branch 'project-chip:master' into master

e69e63c

Merge branch 'project-chip:master' into master

a40f6df

Merge branch 'project-chip:master' into master

e5925ba

Merge branch 'project-chip:master' into master

0435362

Merge branch 'project-chip:master' into master

40b3412

Merge branch 'project-chip:master' into master

d197cb5

Merge branch 'project-chip:master' into master

e9b685d

Merge branch 'project-chip:master' into master

ef11df2

Merge branch 'project-chip:master' into master

b088f83

Merge branch 'project-chip:master' into master

8530810

Merge branch 'project-chip:master' into master

87a9581

Merge branch 'project-chip:master' into master

d9b496d

Merge branch 'project-chip:master' into master

2d283df

Merge branch 'project-chip:master' into master

2639213

Changes for transmitting UpdateApplied for EFR32

a55086f

Delay HandleApply by EFR32_KVS_SAVE_DELAY_SECONDS + 1

e312dcd

Delay HandleApply() to give KVS time to store the data in StoreCurrentUpdateInfo(). Introduce EFR32_KVS_SAVE_DELAY_SECONDS to represent the delay amount KeyValueStoreManagerImpl uses before saving the key/vaule pair

boring-cyborg bot added efr32 examples platform labels May 18, 2022

pullapprove bot requested a review from andy31415 May 18, 2022 23:16

pullapprove bot requested review from saurabhst, tecimovic, tehampson, turon, vijs, vivien-apple, wbschiller, woody-apple, xylophone21 and yunhanw-google May 18, 2022 23:16

pullapprove bot added review - pending efr32 examples platform and removed examples platform efr32 labels May 18, 2022

selissia and others added 4 commits May 18, 2022 19:50

Remove merge artifacts

6f9e50c

Merge branch 'project-chip:master' into master

995a07e

Merge branch 'master' of github.com:selissia/connectedhomeip into sil…

8766890

…abs-image-applied

Restyled by clang-format

cd3e78b

restyled-io bot mentioned this pull request May 18, 2022

Restyle [EFR32] Implement methods for NotifyUpdateApplied after an OTA update #18585

Closed

jmartinez-silabs approved these changes May 19, 2022

View reviewed changes

Damian-Nordic approved these changes May 19, 2022

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels May 19, 2022

Damian-Nordic merged commit 8a872fd into project-chip:master May 19, 2022

selissia deleted the silabs-image-applied branch June 20, 2022 11:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EFR32] Implement methods for NotifyUpdateApplied after an OTA update #18584

[EFR32] Implement methods for NotifyUpdateApplied after an OTA update #18584

selissia commented May 18, 2022 •

edited

Loading

github-actions bot commented May 18, 2022 •

edited

Loading

github-actions bot commented May 19, 2022 •

edited

Loading

[EFR32] Implement methods for NotifyUpdateApplied after an OTA update #18584

[EFR32] Implement methods for NotifyUpdateApplied after an OTA update #18584

Conversation

selissia commented May 18, 2022 • edited Loading

Problem

Change overview

Testing

github-actions bot commented May 18, 2022 • edited Loading

github-actions bot commented May 19, 2022 • edited Loading

selissia commented May 18, 2022 •

edited

Loading

github-actions bot commented May 18, 2022 •

edited

Loading

github-actions bot commented May 19, 2022 •

edited

Loading