-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chip-tool cleanup of subscription clients. #21600
Merged
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-chip-tool-subscription-shutdown
Aug 4, 2022
Merged
Fix chip-tool cleanup of subscription clients. #21600
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-chip-tool-subscription-shutdown
Aug 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #21600: Size comparison from c8a6d37 to d635e61 Increases (3 builds for bl602, telink)
Decreases (3 builds for cyw30739, esp32, mbed)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
/rebase |
We were doing it from the wrong thread in some cases. Fixes project-chip#21599
d635e61
to
bb9d191
Compare
PR #21600: Size comparison from 4ae0b0f to bb9d191 Increases (6 builds for cc13x2_26x2, esp32, nrfconnect, telink)
Decreases (4 builds for cc13x2_26x2, cyw30739, linux)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
Aug 4, 2022
woody-apple
approved these changes
Aug 4, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
We were doing it from the wrong thread in some cases. Fixes project-chip#21599
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were doing it from the wrong thread in some cases.
Fixes #21599
Problem
See issue.
Change overview
Always defer cleanup of subscription commands, and ensure their ReadClients are properly destroyed OnDone.
Testing
Tested steps from issue above; no more asserts.