-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configure nlfaultinjection via fault-cluster in yaml #21951
Merged
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/faultinjection/command
Aug 18, 2022
Merged
Allow configure nlfaultinjection via fault-cluster in yaml #21951
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/faultinjection/command
Aug 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs and
jmartinez-silabs
August 17, 2022 05:12
pullapprove
bot
requested review from
mspang,
rgoliver,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
August 17, 2022 05:12
PR #21951: Size comparison from 4b2de04 to e644722 Increases above 0.2%:
Increases (8 builds for cc13x2_26x2, k32w, linux, nrfconnect, p6)
Decreases (5 builds for cc13x2_26x2, efr32, p6, telink)
Full report (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Aug 17, 2022
cecille
approved these changes
Aug 17, 2022
yunhanw-google
approved these changes
Aug 18, 2022
PR #21951: Size comparison from c037fc2 to a9fbdfa Increases above 0.2%:
Increases (19 builds for cc13x2_26x2, esp32, linux, nrfconnect, p6)
Decreases (3 builds for cc13x2_26x2, p6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…hip#21951) * Define and Enable fault injection cluster * Run codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Nest Labs Fault Injection (nlfaultinjection) is designed to provide a simple, portable fault injection framework, this framework has been integrated in Matter SDK from the beginning, but not get activated anywhere. We need a way to configure these faults from chip-tool so that we can use this mechanism in yaml test.
Fixes nlfaultinjection support into fault-cluster #21941
Change overview
Allow configure nlfaultinjection via fault-cluster in yaml
Testing
How was this tested? (at least one bullet point required)
Build all-clusters-app with nlfaultinjection enabled
scripts/examples/gn_build_example.sh examples/all-clusters-app/linux out/debug/standalone chip_config_network_layer_ble=false chip_with_nlfaultinjection=true
Configure a system fault from chip_tool
./chip-tool faultinjection fail-at-fault 1 1 0 1 true 12344321 0
Confirm the fault is activated from all-clusters-app log