Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SecureSession being made defunct after expiration #23097

Merged

Commits on Oct 10, 2022

  1. Fix SecureSession being made defunct after expiration

    When an UpdateNOC call is received on the server, it expires the
    associated session and proceeds to send back a response on the
    associated exchange. If response fails to get ACK'ed, it will result in
    the session being marked defunct. The SecureSession logic
    over-aggressively asserts on marking expired sessions as defunct,
    causing a VerifyOrDie crash to happen.
    
    Fix:
    Remove the VerifyOrDie
    
    Testing:
    Added a test in TestAbortExchangesForFabric to catch this scenario. Also
    pivoted most of the secure sessions in those test to be of type CASE to
    facilitate correctly triggering the various bits of logic in ExchangeMgr
    and ReliableMessageMgr in these scenarios.
    mrjerryjohns committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    45e4e75 View commit details
    Browse the repository at this point in the history