Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move codegen.py invoke logic into a gni template #23154

Merged
merged 16 commits into from
Oct 14, 2022
Merged

Move codegen.py invoke logic into a gni template #23154

merged 16 commits into from
Oct 14, 2022

Commits on Oct 12, 2022

  1. Move codegen logic into a standalone gni template

    @andy31415
    andy31415 committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    42a7f93 View commit details
    Browse the repository at this point in the history

  2. Remove extra hadcoded path in codegen.gni

    @andy31415
    andy31415 committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    328d4c2 View commit details
    Browse the repository at this point in the history

  3. Remove extra hadcoded path in codegen.gni

    @andy31415
    andy31415 committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    eab7717 View commit details
    Browse the repository at this point in the history

  4. Use common codegen instruction for bridge as well

    @andy31415
    andy31415 committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    f21d187 View commit details
    Browse the repository at this point in the history

  5. Make sure that the codegen include is a public target, so that includ… 

    …es work for generated code
    @andy31415
    andy31415 committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    48ad545 View commit details
    Browse the repository at this point in the history

  6. Restyle

    @andy31415
    andy31415 committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    8d2e9e5 View commit details
    Browse the repository at this point in the history

  7. Enforce that outputs in the codegen are known rather than dynamic

    @andy31415
    andy31415 committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    c758819 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Apply some code review comments

    @andy31415
    andy31415 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    9cbe3db View commit details
    Browse the repository at this point in the history

  2. rephrased a comment based on code review

    @andy31415
    andy31415 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    afecdf6 View commit details
    Browse the repository at this point in the history

  3. Restyle

    @andy31415
    andy31415 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    f8be3ec View commit details
    Browse the repository at this point in the history

  4. Stop using exec_script in gn (faster gn)

    @andy31415
    andy31415 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    6ced431 View commit details
    Browse the repository at this point in the history

  5. Fix path rebasing to get valid paths

    @andy31415
    andy31415 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    eda8105 View commit details
    Browse the repository at this point in the history

  6. Restyle

    @andy31415
    andy31415 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    e752d8d View commit details
    Browse the repository at this point in the history

  7. make sure that generated expected outputs is one of the expected inpu… 

    …t files for the codegen script
    @andy31415
    andy31415 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    917fc63 View commit details
    Browse the repository at this point in the history

  8. Add documentation on how to get the list of expected files

    @andy31415
    andy31415 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    7d2bf3a View commit details
    Browse the repository at this point in the history

  9. Add missing init call in the test storage impl

    @andy31415
    andy31415 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    4470e36 View commit details
    Browse the repository at this point in the history