-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align naming in Groups cluster XML with the spec. #24236
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:rename-group-bits
Jan 3, 2023
Merged
Align naming in Groups cluster XML with the spec. #24236
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:rename-group-bits
Jan 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes the incorrect ClusterRevision value in the XML.
Damian-Nordic
approved these changes
Jan 3, 2023
e8c6193
to
7b73a8d
Compare
tehampson
approved these changes
Jan 3, 2023
msandstedt
approved these changes
Jan 3, 2023
PR #24236: Size comparison from 8f9207d to 7b73a8d Increases (13 builds for bl602, bl702, linux, psoc6, telink)
Decreases (7 builds for bl702, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes the incorrect ClusterRevision value in the XML.
REVIEW NOTE: Only the first commit contains manual changes.