-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test suite setup and teardown functions static #33330
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #33330: Size comparison from 4957dc8 to 40bb8a8 Decreases (2 builds for efr32)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink)
|
arkq
reviewed
May 7, 2024
40bb8a8
to
3cfc491
Compare
arkq
approved these changes
May 7, 2024
PR #33330: Size comparison from bc0f5ee to 60f1f43 Decreases (2 builds for efr32)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink)
|
andy31415
approved these changes
May 7, 2024
feasel0
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
60f1f43
to
0ae4488
Compare
PR #33330: Size comparison from e079364 to 0ae4488 Decreases (2 builds for efr32)
Full report (77 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink)
|
PR #33330: Size comparison from 3219a5f to b3a10cf Decreases (2 builds for efr32)
Full report (78 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink)
|
b5825da
to
68b73e9
Compare
PR #33330: Size comparison from 3219a5f to 68b73e9 Decreases (2 builds for efr32)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to migrate to pw_unit_test,
SetUpTestSuite
andTearDownTestSuite
ought to be static member functions of a test fixture class.But nltest still expects them to take a
void *
argument and return an int, so I wrap them with macros each time they're used inside anlTestSuite
declaration.Followup: Remove
NL_TEST_WRAP_FUNCTION
andNL_TEST_WRAP_METHOD
, when they are no longer needed.These changes used to be part of #33002, but that PR was split into smaller pieces.