-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP] Add ESP32C3 DevKitM support to all-clusters-app #6345
Conversation
@NoyceOne0630 Thanks for the contribution! Can you please sign the CLI, and also restyle the PR per the instructions in: |
Not supportedconnectedhomeip/src/platform/ESP32/nimble/BLEManagerImpl.cpp Lines 584 to 594 in 6318fa7
This comment was generated by todo based on a
|
fail connection???connectedhomeip/src/platform/ESP32/nimble/BLEManagerImpl.cpp Lines 819 to 829 in 6318fa7
This comment was generated by todo based on a
|
the riscv legacy __sync APIs will be added to esp-idf release/v4.3 soon. |
/rebase |
74b8d43
to
dd714a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the updated template, can you update the PR here?
#### Problem
What is being fixed? Examples:
* Fix crash on startup
* Fixes #12345 12345 Frobnozzle is leaky (exactly like that, so GitHub will auto-close the issue).
#### Change overview
What's in this PR
#### Testing
How was this tested? (at least one bullet point required)
• If unit tests were added, how do they cover this issue?
• If unit tests existed, how were they fixed/modified to prevent this in future?
• If integration tests were added, how do they verify this change?
• If manually tested, what platforms controller and device platforms were manually tested, and how?
• If no testing is required, why not?
esp32c3 support needs idf version v4.3 or later, but pigweed app build fail with idf v4.3, error log shows
will update after this PR merged |
dd714a7
to
4d947e8
Compare
4d947e8
to
f423381
Compare
f423381
to
f6209fe
Compare
@@ -10,3 +10,6 @@ pygdbmi<=0.9.0.2 | |||
reedsolo>=1.5.3,<=1.5.4 | |||
bitstring>=3.1.6 | |||
ecdsa>=0.16.0 | |||
kconfiglib==13.7.1 | |||
construct==2.10.54 | |||
python-socketio<5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mspang Can you please review the scripts related changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the problem with version 5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mspang I was just referring to the generic changes in requirements.txt for ESP32. Nothing specific :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is nothing specific then please do not use a less-than requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As documented there: https://github.com/espressif/esp-idf/blob/v4.3/requirements.txt#L20, there was some compatible issue. We will check with our tools team, and update upstream if the issue has been fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bug link.
Sure! Please raise a Github issue to track this |
e09c5df
to
26fa994
Compare
8e79787
to
24d9461
Compare
/rebase |
1198ebe
to
ccccca6
Compare
@wqx6 Please rebase and resolve conflicts. |
ccccca6
to
5ad009a
Compare
@@ -10,3 +10,6 @@ pygdbmi<=0.9.0.2 | |||
reedsolo>=1.5.3,<=1.5.4 | |||
bitstring>=3.1.6 | |||
ecdsa>=0.16.0 | |||
kconfiglib==13.7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be >= ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same as the file requirements.txt
in our ESP-IDF Release v4.3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, can you fix it upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mspang, we will double check with our tools team on this specific requirement. Meantime, could we merge it as is, since it's located in requirements.esp32.txt
, and we will update after our upsteam change is ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll hold you to that.
@@ -10,3 +10,6 @@ pygdbmi<=0.9.0.2 | |||
reedsolo>=1.5.3,<=1.5.4 | |||
bitstring>=3.1.6 | |||
ecdsa>=0.16.0 | |||
kconfiglib==13.7.1 | |||
construct==2.10.54 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be >= ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
Size increase report for "esp32-example-build" from 8a53528
Full report output
|
@andy31415 Can you update the chip-build-esp32 Dockerfile? We have updated the dockerfile using ESP-IDF release tag v4.3 in this PR. |
Problem
Need to add ESP32C3 support to the all-clusters-app.
Summary of Changes
Testing