-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a NodeId header and some NodeId utilities #8465
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider making this a class and the various utility methods staticconnectedhomeip/src/lib/core/NodeId.h Lines 24 to 34 in 2de562c
This comment was generated by todo based on a
|
msandstedt
reviewed
Jul 19, 2021
2de562c
to
ae9f1a0
Compare
@msandstedt @tcarmelveilleux Please take a look? |
5683431
to
a11c2f4
Compare
Size increase report for "esp32-example-build" from d24b3c0
Full report output
|
emargolis
approved these changes
Jul 20, 2021
jelderton
approved these changes
Jul 20, 2021
msandstedt
approved these changes
Jul 20, 2021
91980b7
to
ada92cf
Compare
Ideally we'd just ask for an operational cert for the commissionnee
This comment was generated by todo based on a
|
Fixes project-chip#8461 The encoder.cpp changes are needed because it used to bootleg the PacketBuffer header via basic-types.h including MessageHeader.h, instead of doing include-what-you-use correctly.
ada92cf
to
af22b22
Compare
Ideally we'd just ask for an operational cert for the commissionnee
This comment was generated by todo based on a
|
tcarmelveilleux
approved these changes
Jul 20, 2021
@woody-apple @mspang @jepenven-silabs @jmartinez-silabs @Damian-Nordic Please take a look? |
jmartinez-silabs
approved these changes
Jul 21, 2021
This was referenced Jul 21, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Fixes project-chip#8461 The encoder.cpp changes are needed because it used to bootleg the PacketBuffer header via basic-types.h including MessageHeader.h, instead of doing include-what-you-use correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8461
The encoder.cpp changes are needed because it used to bootleg the
PacketBuffer header via basic-types.h including MessageHeader.h,
instead of doing include-what-you-use correctly.
Problem
Could use a utility to generate spec-valid random operational node ids.
Change overview
Add such a utility.
Testing
Made sure that chip-tool is still generating random node ids when it should.