Remove irrelevant external metrics APIService resources #277
Conversation
ChristianZaccaria
requested review from
astefanutti
and removed request for
Maxusmusti and
jbusche
ChristianZaccaria
force-pushed
the
agent-mode-only-mcad
branch
from
d4d30f5
to
c7e2908
Compare
| @@ -22,7 +22,6 @@ import ( | |||
|
|
|||
| var multiClusterAppDispatcherTemplates = []string{ | |||
| "mcad/configmap.yaml.tmpl", | |||
| "mcad/service.yaml.tmpl", | |||
| "mcad/serviceaccount.yaml.tmpl", | |||
| "mcad/deployment.yaml.tmpl", | |||
There was a problem hiding this comment.
I think the corresponding ports from the Deployment can also be removed:
ports:
- name: https
containerPort: 6443
protocol: TCP
- name: http
containerPort: 8080
protocol: TCPThere was a problem hiding this comment.
Great catch! Changes were made now.
I do have a few thoughts though. Should we also be removing items from the MCAD test data ?
I.e., in mcad_test_results, there are some rolebindings and the same mentioned ports in the deployment of these tests.
These tests seem to run on the tag-and-build workflow.
There was a problem hiding this comment.
Great catch too! Indeed, these test data files should be amended accordingly too.
There was a problem hiding this comment.
Excellent, the respective files have been removed. Waiting on tests to pass.
ChristianZaccaria
force-pushed
the
agent-mode-only-mcad
branch
from
c7e2908
to
22e9523
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
Closes #247
What changes have been made
As mentioned in the issue: The multi-cluster mode provided by MCAD is experimental and is not used. Even if the multi-cluster mode is deactivated by default, a number of resources are installed only for the purpose of its operation.
For this reason, we are removing the APIService resources and ClusterRoleBindings that are irrelevant to the single cluster setup.
The removal of the CRBs was done as part of this PR #270
Checks