Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed variable to avoid double negation #609

Merged

Conversation

KPostOffice
Copy link
Contributor

@KPostOffice KPostOffice commented Aug 25, 2023

Issue link

NONE

What changes have been made

I changed a variable to avoid a double negative in a conditional

Verification steps

I don't think this needs to be tested as these are the only two instances of the variable, but lmk if you think otherwise

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Signed-off-by: Kevin <kpostlet@redhat.com>
@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/retest

1 similar comment
@KPostOffice
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Aug 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f05c6a8 into project-codeflare:main Aug 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants