fix: google distroless patching for libssl1.1 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeMonkeyLeet
requested review from
jeremyrickard,
salaxander and
sozercan
as code owners
- Match naming of libssl1.1 status.d control file to match libssl1 as provided by the distroless base image. This implementation truncates all package file names to the first period, which does not affect other existing packages in the base images seen in the distroless images test set, but may need to be revisited if that behavior changes. - Add test case for libssl1.1 patching. - Fix failure to copy unpacked update files to target image if the tooling image already has the latest versions of the files. dpkg.go now unpacks the update files to a separate root and copies those into a layer for merge into the target image instead of relying of a diff layer after unpacking the update files into the tooling image. - Clarify in comments for rpm.go why the distroless patching behavior differs from dpkg.go. Signed-off-by: Simon Leet <simon.leet@microsoft.com>
CodeMonkeyLeet
force-pushed
the
fix_libssl_patching
branch
from
588d8d7
to
534f291
Compare
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 27 27
=========================================
Hits 27 27 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
CodeMonkeyLeet
pushed a commit
to CodeMonkeyLeet/copacetic
that referenced
this pull request
Feb 21, 2023
Remove debug image creation introduced in project-copacetic#41. Signed-off-by: Simon Leet <simon.leet@microsoft.com>
sozercan
pushed a commit
to sozercan/copacetic
that referenced
this pull request
Mar 14, 2023
sozercan
pushed a commit
to sozercan/copacetic
that referenced
this pull request
Mar 14, 2023
Remove debug image creation introduced in project-copacetic#41. Signed-off-by: Simon Leet <simon.leet@microsoft.com>
sozercan
pushed a commit
to sozercan/copacetic
that referenced
this pull request
Mar 14, 2023
Remove debug image creation introduced in project-copacetic#41. Signed-off-by: Simon Leet <simon.leet@microsoft.com>
sozercan
added a commit
that referenced
this pull request
Mar 15, 2023
ashnamehrotra
pushed a commit
to ashnamehrotra/copacetic
that referenced
this pull request
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37