Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add apk add #60

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Mar 9, 2023

Add apk packages before upgrading. This works around the issue where packages require other packages in the dependency tree to be updated.

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.19 ⚠️

Comparison is base (60433a8) 34.45% compared to head (3de4586) 34.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   34.45%   34.27%   -0.19%     
==========================================
  Files          12       12              
  Lines        1126     1132       +6     
==========================================
  Hits          388      388              
- Misses        717      723       +6     
  Partials       21       21              
Impacted Files Coverage Δ
pkg/pkgmgr/apk.go 45.23% <0.00%> (-2.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copy link
Contributor

@CodeMonkeyLeet CodeMonkeyLeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Interesting find that just apk add fixes up the dependency tree for the package independent of versioning.

@CodeMonkeyLeet CodeMonkeyLeet merged commit adc6f10 into project-copacetic:main Mar 9, 2023
@sozercan sozercan deleted the fix-apk-add branch March 9, 2023 21:45
sozercan added a commit that referenced this pull request Mar 15, 2023
Co-authored-by: Simon Leet <simon.leet@microsoft.com>
ashnamehrotra pushed a commit to ashnamehrotra/copacetic that referenced this pull request Aug 25, 2023
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants