Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(costmodel): clean unnecessary code in cost model header #1586

Merged
merged 1 commit into from
Jun 25, 2020
Merged

refactor(costmodel): clean unnecessary code in cost model header #1586

merged 1 commit into from
Jun 25, 2020

Conversation

boaz0
Copy link
Contributor

@boaz0 boaz0 commented Jun 24, 2020

Remove the cmpRef variable - this is no longer needed.
Change the component into a functional component.

@boaz0
refactor(costmodel): clean unnecessary code in cost model header
5ba3241 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@boaz0 boaz0 added the cost model cost models, create cost model wizard label Jun 24, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #1586 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1586   +/-   ##
=======================================
  Coverage   78.33%   78.33%           
=======================================
  Files         235      235           
  Lines        3886     3886           
  Branches      716      716           
=======================================
  Hits         3044     3044           
  Misses        743      743           
  Partials       99       99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d68a9a...5ba3241. Read the comment docs.

ddonahue007
ddonahue007 approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@ddonahue007 ddonahue007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boaz0
Copy link
Contributor Author

boaz0 commented Jun 25, 2020

Thanks @ddonahue007

@boaz0 boaz0 merged commit 0e18cfb into project-koku:master Jun 25, 2020
@boaz0 boaz0 deleted the nitpick_costmodel_header branch June 25, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddonahue007 ddonahue007 ddonahue007 approved these changes

@dlabrecq dlabrecq Awaiting requested review from dlabrecq

Assignees
No one assigned
Labels
cost model cost models, create cost model wizard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boaz0 @codecov-commenter @ddonahue007