Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4230] - add cluster-id to basic auth log message #4827

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Dec 12, 2023

Jira Ticket

COST-4230

Description

This change adds cluster-id to the log message for basic auth operator payloads and converts to an INFO message rather than WARNING (Kibana is not parsing the keys for these messages and it may be due to the characters used to change the color of the logs)

@maskarb maskarb requested review from a team as code owners December 12, 2023 14:02
@maskarb maskarb added the smoke-tests pr_check will build the image and run minimal required smokes label Dec 12, 2023
@maskarb
Copy link
Member Author

maskarb commented Dec 12, 2023

/retest

@maskarb maskarb enabled auto-merge (squash) December 12, 2023 14:05
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #4827 (738116d) into main (9999949) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4827   +/-   ##
=====================================
  Coverage   93.9%   93.9%           
=====================================
  Files        361     361           
  Lines      29900   29900           
  Branches    3562    3562           
=====================================
+ Hits       28076   28081    +5     
+ Misses      1162    1160    -2     
+ Partials     662     659    -3     

Copy link

sonarcloud bot commented Dec 12, 2023

@maskarb maskarb added hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix and removed smoke-tests pr_check will build the image and run minimal required smokes labels Dec 12, 2023
@maskarb
Copy link
Member Author

maskarb commented Dec 12, 2023

/retest

@maskarb maskarb merged commit d758158 into main Dec 12, 2023
10 checks passed
@maskarb maskarb deleted the basic-auth-log-cluster-id branch December 12, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants