-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-3814] Add Azure source processing to subs flow #4831
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgoodfred
added
the
aws-smoke-tests
pr_check will build the image and run aws + ocp on aws smoke tests
label
Dec 13, 2023
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
djnakabaale
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 👍🏾
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4831 +/- ##
=======================================
- Coverage 94.0% 94.0% -0.0%
=======================================
Files 364 364
Lines 30132 30204 +72
Branches 3589 3598 +9
=======================================
+ Hits 28312 28379 +67
- Misses 1160 1164 +4
- Partials 660 661 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
COST-3814
Description
This change will add Azure processing to the subs flow. It extends the AWS processing to handle Azure sources. We are processing the same information as before with an additional tag option of
com_redhat_rhel_instance
to allow someone to add that tag instead of giving the additional Reader permission to the Azure scope.Example of a kafka message that would be sent:
Testing
com_redhat_rhel
tag on a VM. (reach out to Corey if you need credentials for a source that has this)Notes
The AWS smokes label was run to ensure no regression in the AWS Subs Processing flow since there are not yet smokes for the Azure flow.
Example from setting only
AWS
enabled in the environment to give us more control over where different providers process:...