Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MONAI-ITK orientation. Improve Writer docstrings. #81

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Conversation

ibro45
Copy link
Collaborator

@ibro45 ibro45 commented Sep 24, 2023

Description

Removed my temp fix for Project-MONAI/MONAI#6985 as it has been fixed.

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@surajpaib
Copy link
Collaborator

surajpaib commented Sep 24, 2023

@ibro45 We should also set the monai version in poetry. Otherwise this fix doesn't work right?

@surajpaib
Copy link
Collaborator

Right now, we have this,

monai-weekly = "^1.2.dev2305"

It will pull the latest one if available, but it's not necessary that it picks up the version with this fix.

@ibro45
Copy link
Collaborator Author

ibro45 commented Sep 24, 2023

Cool will do it thanks

Copy link
Collaborator

@surajpaib surajpaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibro45
Copy link
Collaborator Author

ibro45 commented Nov 16, 2023

Thanks Suraj!

@ibro45 ibro45 merged commit f62bf9a into main Nov 16, 2023
7 checks passed
@ibro45 ibro45 deleted the lps-ras-fixed branch November 16, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants