Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs to stage1 #4653

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tiziano88
Copy link
Collaborator

There is room for improvement, but I want to get something in to debug other issues, and also to have some precedent in the code for other people to then add more logs and improve on.

Ref #4652

@andrisaar
Copy link
Collaborator

A fair chunk of these definitely aren't relevant most of the time, and thus should be only debug logs.

It's not like we have a way how to filter these (as at this stage all messages get dumped to the serial console), but could we use the log (or tracing) crate to set the log levels properly, even if we always print everything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants