Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doubles Stats #54

Merged
merged 32 commits into from
Apr 13, 2021
Merged

Doubles Stats #54

merged 32 commits into from
Apr 13, 2021

Conversation

OGoodness
Copy link
Contributor

Added the ability to calculate doubles stats.
Treat every other player on the stage as an opponent during combo.

Change perspective of combos/conversions to be from the victims point of view.
Combos now belong to the victim, you can identify whos combo it is by checking the moveIds.
Conversions now also belong to the victim.

Can calculate stats for free-for-all, teams, and 1v1.
Overall, the character handling should be more generalized.

Also added test cases for src/melee and src/console

vinceau
vinceau reviewed Feb 3, 2021
View reviewed changes
Copy link
Member

@vinceau vinceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the most part I'm very happy with this PR. Only have some thoughts and comments regarding the overall stats.

src/stats/overall.ts Outdated Show resolved Hide resolved
OGoodness and others added 14 commits February 8, 2021 14:47
@OGoodness
Updated to merge multidimensional array of stats into a single, gamew…
d14599b 
…ide statistic
@OGoodness
Updated to merge multidimensional array of stats into a single, gamew…
7c72ca5 
…ide statistic
@OGoodness
Updated to exclude team members from stat analysis. Also added teamMe…
049a3a7 
…mbers to object
@OGoodness
Updated to exclude team members from stat analysis. Also added teamMe…
2cd32c0 
…mbers to object
@vinceau
refactor(stats): completely remove PlayerIndexedType
400b5a8
@vinceau
style(eslint): allow object shorthand notation
c5ce145
@vinceau
feat(stats): store lastHitBy in combos and conversions to track kills
d19f48c
@vinceau
fix(stats): fix damage done and kill count calculation.
a78c5c8 
It's naive to think that we did all the damage and took all the kills in
a FFA/teams game. Fix the overall stats calculation accordingly.
@OGoodness
Merge remote-tracking branch 'upstream/master'
1550b44
@OGoodness
Merge remote-tracking branch 'upstream/master'
ac6c09e
@OGoodness
Updated Doubles stats with changes from master, handles command grab
14a8578
@OGoodness
Got all the tests passing
ad43b2e
@OGoodness
Got all the tests passing
94a6a36
@OGoodness
Got all the tests passing
a7a308e
vinceau
vinceau approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@vinceau vinceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinceau vinceau merged commit 3de9791 into project-slippi:master Apr 13, 2021
vinceau added a commit that referenced this pull request May 10, 2021
@vinceau
Revert "Doubles Stats (#54)"
5c55aa8 
This reverts commit 3de9791.
vinceau added a commit that referenced this pull request May 10, 2021
@vinceau
Revert "Doubles Stats (#54)" (#71)
ca5b5ee 
* Revert "Doubles Stats (#54)"

This reverts commit 3de9791.

* refactor: remove player indices from SlippiGame
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinceau vinceau vinceau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OGoodness @vinceau