Add network diagnostic tool to Help Box #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikhilNarayana
requested changes
Sep 17, 2023
NikhilNarayana
previously requested changes
Sep 19, 2023
|
|
looks nice! updated screenshot https://imgur.com/a/aab8SU0 |
vinceau
requested changes
Sep 20, 2023
vinceau
reviewed
Sep 20, 2023
done! |
vinceau
requested changes
Sep 29, 2023
There was a problem hiding this comment.
Getting there!
I've noticed a few common things:
- Prefer returning a
<div>over returning react fragments, unless the structure of the DOM is important enough to require you to. - Prefer returning
nullover an empty react fragment<></>. - Prefer inline text content
<div>text</div>over wrapping in a string literal<div>{"text"}</div>
src/renderer/containers/Settings/NetworkDiagnostic/CgnatCommandSection.tsx
Outdated
Show resolved
Hide resolved
src/renderer/containers/Settings/NetworkDiagnostic/PortMappingSection.tsx
Outdated
Show resolved
Hide resolved
src/renderer/containers/Settings/NetworkDiagnostic/CgnatSection.tsx
Outdated
Show resolved
Hide resolved
src/renderer/containers/Settings/NetworkDiagnostic/NetworkDiagnosticsButton.tsx
Outdated
Show resolved
Hide resolved
all comments addressed! |
- add show/hide toggle for external ip address - add copy buttons - refine cgnat test failure ui
section tsx ternary -> arrow function
move diagnostic to help page
2.0.1 has broken `index.d.ts` so use 2.0.0 instead
This would make sense to explain what the network diagnostic would do before starting it, but doesn't make any sense to include once the user can see what the network diagnostic is doing
vinceau
force-pushed
the
networkdiagnostic
branch
from
294e8d2
to
f9bf13d
Compare
vinceau
approved these changes
Sep 29, 2023
NikhilNarayana
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier for users and support volunteers to debug some network issues
screenshots: https://imgur.com/a/4iNsmec
In the future, I intend to hook up the port mapping test to a slippi dolphin port mapping option (IE. press a button to turn on slippi dolphin port mapping if port mapping is available)