Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logging at start/end of datastore::shutdown() #32

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

ban-nobuhiro
Copy link
Contributor

For project-tsurugi/tsurugi-issues#189.

どこをもって終了(end)とすべきなのかは検討の余地があると思いますが、この位置とします。
現状では、呼び出した shirakami がこの future を捨てるため、そこで wait するようです。

@ban-nobuhiro ban-nobuhiro merged commit 464246a into master Apr 7, 2023
@t-horikawa
Copy link
Contributor

お分かりと思いますが、std::chrono::microseconds(100000)に必然性は全くありません。
shutdownをrequest(call)された際、limestoneの後始末を非同期に行わせ、その完了をfutureで伝える、というのが本来の想定です。
limestoneの実装が充実し、そういった動作を行わせるようになったら、それに合わせて頂く必要があります。

@ban-nobuhiro ban-nobuhiro deleted the logging-shutdown-start-end branch October 3, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants