User preferences support #1317
Merged
User preferences support #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentiuNiculae
force-pushed
the
userdb-support
branch
5 times, most recently
from
9fbf9b9
to
6bdf70b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1317 +/- ##
==========================================
+ Coverage 90.52% 90.66% +0.13%
==========================================
Files 98 100 +2
Lines 21480 22217 +737
==========================================
+ Hits 19445 20143 +698
- Misses 1521 1544 +23
- Partials 514 530 +16
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Mar 30, 2023
Closed
laurentiuNiculae
force-pushed
the
userdb-support
branch
10 times, most recently
from
d1a5411
to
1c7eeaf
Compare
laurentiuNiculae
requested review from
shimish2,
rchincha,
andaaron and
peusebiu
as code owners
laurentiuNiculae
commented
Apr 5, 2023
laurentiuNiculae
commented
Apr 5, 2023
laurentiuNiculae
force-pushed
the
userdb-support
branch
from
1c7eeaf
to
45fba7d
Compare
andaaron
reviewed
Apr 10, 2023
laurentiuNiculae
force-pushed
the
userdb-support
branch
3 times, most recently
from
d937585
to
82aa1ff
Compare
laurentiuNiculae
force-pushed
the
userdb-support
branch
from
4824d05
to
2c640f8
Compare
andaaron
previously approved these changes
Apr 19, 2023
laurentiuNiculae
force-pushed
the
userdb-support
branch
2 times, most recently
from
de78ebc
to
c130160
Compare
andaaron
previously approved these changes
Apr 20, 2023
rchincha
reviewed
Apr 20, 2023
rchincha
reviewed
Apr 20, 2023
rchincha
reviewed
Apr 20, 2023
rchincha
reviewed
Apr 20, 2023
rchincha
reviewed
Apr 20, 2023
laurentiuNiculae
force-pushed
the
userdb-support
branch
2 times, most recently
from
eb0e568
to
826c39b
Compare
andaaron
reviewed
Apr 24, 2023
laurentiuNiculae
force-pushed
the
userdb-support
branch
from
826c39b
to
3fee8f5
Compare
andaaron
reviewed
Apr 24, 2023
Initial code was contributed by Bogdan BIVOLARU <104334+bogdanbiv@users.noreply.github.com> Moved implementation from a separate db to repodb by Andrei Aaron <aaaron@luxoft.com> Not done yet: - run/test dynamodb implementation, only boltdb was tested - add additional coverage for existing functionality - add web-based APIs to toggle the stars/bookmarks on/off Initially graphql mutation was discussed for the missing API but we decided REST endpoints would be better suited for configuration Signed-off-by: Andrei Aaron <aaaron@luxoft.com> feat(userdb): complete functionality for userdb integration - dynamodb rollback changes to user starred repos in case increasing the total star count fails - dynamodb increment/decrement repostars in repometa when user stars/unstars a repo - dynamodb check anonymous user permissions are working as intendend - common test handle anonymous users - RepoMeta2RepoSummary set IsStarred and IsBookmarked Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com> feat(userdb): rest api calls for toggling stars/bookmarks on/off Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com> test(userdb): blackbox tests Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com> test(userdb): move preferences tests in a different file with specific build tags Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com> feat(repodb): add is-starred and is-bookmarked fields to repo-meta - removed duplicated logic for determining if a repo is starred/bookmarked Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
laurentiuNiculae
force-pushed
the
userdb-support
branch
from
3fee8f5
to
b862f99
Compare
andaaron
approved these changes
Apr 24, 2023
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
Closes #592
Closes #662
Closes #746
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.