Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gc): gc now removes blob uploads which have not changed within the gc delay interval #2599

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

andaaron
Copy link
Contributor

@andaaron andaaron commented Aug 9, 2024

See #2598

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 79.54545% with 9 lines in your changes missing coverage. Please review.

Project coverage is 92.69%. Comparing base (2dea22f) to head (379205e).

Files Patch % Lines
pkg/storage/gc/gc.go 69.23% 6 Missing and 2 partials ⚠️
pkg/storage/imagestore/imagestore.go 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2599      +/-   ##
==========================================
- Coverage   92.74%   92.69%   -0.05%     
==========================================
  Files         169      169              
  Lines       22471    22512      +41     
==========================================
+ Hits        20840    20868      +28     
- Misses       1015     1025      +10     
- Partials      616      619       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…e gc delay interval

See project-zot#2598

Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 253aad3 into project-zot:main Aug 12, 2024
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants