Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native preset disable config flag #99

Closed
revmischa opened this issue Sep 2, 2018 · 12 comments
Closed

Native preset disable config flag #99

revmischa opened this issue Sep 2, 2018 · 12 comments
Labels

Comments

@revmischa
Copy link
Collaborator

I think the native presets are not very interesting and should be disabled by default. If someone wants to make some cool native presets they can enable it, but normal users have no need for this functionality.

@Chinmaygoyal
Copy link

Can I work on this issue?

@revmischa
Copy link
Collaborator Author

@Chinmaygoyal go for it!

@Chinmaygoyal
Copy link

I am new to open source and have never made a PR before so can you help me by providing a start?

@revmischa
Copy link
Collaborator Author

Sure, there are lots of helpful articles if you click "Help" at the bottom of this page
Like this one: https://help.github.com/en/articles/fork-a-repo

@Purukitto
Copy link

Has this been solved?

@revmischa
Copy link
Collaborator Author

Nope

@AdityaC45
Copy link

Has this been solved? If not then I would like to help

@revmischa
Copy link
Collaborator Author

Please feel free

@zuberrahman
Copy link

Hi, I'd like to contribute to this project, I've forked this already and I'd like to know where I should start working and get some assistance.

@revmischa
Copy link
Collaborator Author

Hi, I'd like to contribute to this project, I've forked this already and I'd like to know where I should start working and get some assistance.

Great! Join the discord! Look through open issues or fix something that bothers you. Documentation needs improving, downstream packages need maintaining.

@kblaschke
Copy link
Member

Native presets can now be enabled via a CMake parameter and are disabled by default, but there's still no config setting to prevent them from being loaded if they are installed.

@kblaschke
Copy link
Member

With disabled native preset support in the CMake build (which is the default), the whole native preset loading code won't be compiled into the library at all. As these presets have numerous issues with stability, security and portability, this issue should be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants