Search preloaded random textures in TextureManager::GetRandomTexture #783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently only check textures loaded from files when selecting a random texture. Since we purge textures between presets, if a preset uses something like
sampler_rand00
, no presets will be found, the returned sampler will be null, and we end up creating invalid GLSL. This PR doesn't check the results ofGetRandomSampler
to make sure they're valid, but does extendGetRandomSampler
to include preloaded textures. As this list includes volumetric textures, also filter textures by type. This type defaults to 2D textures and is not otherwise specified elsewhere as I can't find evidence thatGetRandomSampler
is ever expected to return a 3D texture.