Ensure proper threads for InterProcessMutex #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewWestberg
requested review from
escobarjonatan,
wlara and
saif-software-developer
AndrewWestberg
force-pushed
the
amw/interprocessmutex_coroutines
branch
from
46667f3
to
c68d4f7
Compare
wlara
approved these changes
Sep 23, 2024
| // This extension function ensures that the block() is executed on the same thread as the lock and | ||
| // releases the lock after the block is executed on the same thread. | ||
|
|
||
| @OptIn(ExperimentalCoroutinesApi::class) |
There was a problem hiding this comment.
Should we still be using ExperimentalCoroutinesApi ? Curious if we need to update kotlin versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way coroutines work, it's possible to resume on a different thread after a suspend function. This creates an extension function so we can use InterProcessMutex with coroutines to ensure we resume on the same physical JVM thread. This allows us to confidently release() the interprocess mutex since it will be acquired and released on the same physical JVM thread.