Add Platform GOP Policy #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfang
requested changes
May 13, 2020
|
@peterfang Hi, peter. The GUID has changed, please review it, thanks. |
peterfang
approved these changes
May 13, 2020
|
Approved. Handing over to @yuchuyang for SDL review. |
peterfang
requested changes
May 13, 2020
| @@ -0,0 +1,50 @@ | |||
| # | |||
| # | |||
| # Copyright (c) 1999 - 2014, Intel Corporation. All rights reserved | |||
| # | ||
| # The following information is for reference only and not required by the build tools. | ||
| # | ||
| # VALID_ARCHITECTURES = IA32 |
There was a problem hiding this comment.
This is just for reference but can we update this to X64? Or "IA32 X64"?
There was a problem hiding this comment.
This is just for reference but can we update this to X64? Or "IA32 X64"?
ok.
yuchuyang
approved these changes
May 13, 2020
|
@peterfang Hi, peter. The minor changes have done. Please review it, thanks. |
peterfang
approved these changes
May 14, 2020
GOP driver has dependency on PlatformGopPolicy protocol, especially the GetVbtData() interface. v2 -> v1: change GUID Tracked-On: projectacrn/acrn-hypervisor#4365 Signed-off-by: Xiong Zhang <xiong.y.zhang@intel.com> Signed-off-by: Junming Liu <junming.liu@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOP driver has dependency on PlatformGopPolicy protocol,
especially the GetVbtData() interface.
Tracked-On: projectacrn/acrn-hypervisor#4365
Signed-off-by: Xiong Zhang xiong.y.zhang@intel.com
Signed-off-by: Junming Liu junming.liu@intel.com