Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: add virtio_mei mediator #1536

Closed
tomasbw opened this issue Oct 20, 2018 · 1 comment
Closed

dm: add virtio_mei mediator #1536

tomasbw opened this issue Oct 20, 2018 · 1 comment
Assignees
@tomasbw
Labels
area: device model priority: medium status: closed The issue been closed type: feature New feature

Comments

@tomasbw
Copy link
Contributor

tomasbw commented Oct 20, 2018

The MEI device mediator works over virtualization enabled mei device and mei driver.
Currently it only supports MEI on APL-I with HBM version 2.2
And as well it requires an SOS kernel with mei virtualization support.
For other platforms only passthru mode is enabled.
tomasbw added a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: remove virtio_heci
43ca3db 
Remove virtio_heci to be replaced with virtio_mei

Tracked-On: projectacrn#1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw added a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: mei: add mei hbm protocol definitions header.
bf64068 
HBM is a control channel protocol between mei device
driver and mei fw.

Add new ioctl IOCTL_MEI_CONNECT_CLIENT_VTAG

Tracked-On: projectacrn#1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw pushed a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@ausyskin @tomasbw
dm: mei: add guid handling functions
43ce3bf 
libuuid sports only uuid (big endian encoding),
though mei requires guids (little endian encoding).
The base types are based on <linux/uuid.h> header.

Tracked-On: projectacrn#1536
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw added a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: types: add container_of macro
342610e 
Add standard container_of macro to access
the parent struct pointer.

Tracked-On: projectacrn#1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw added a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: mei: add reference counter functions
6bee246 
mei handles objects on the list, hence reference counting
infrastructure is required for easier multithreading.

Tracked-On: projectacrn#1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw added a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: mei: add sysfs read functions
da0eb9c 
mei requires reading of u8, u32 and uuid
sysfs files.

Tracked-On: projectacrn#1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw added a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: mei: add virtio configuration
ae43184 
The virtio has two virtio queues, TX and RX.
TX have two segment buffers one for header and one for data.
The virtio_mei declares host buffer of size 128 slots, each
slot is a 4 bytes value.
For synchronization hw_ready and host_reset configuration flags
are used that emulates mei reset flow.
And last fw status registers must be also readable via virtio
mei device.

Tracked-On: projectacrn#1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw added a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: mei: add client management infrastructure
30cf247 
1. virtio_mei structure represents an instance of mei device.
2. vmei_me_client represents an ME application in the MEI FW.
3. vmei_host_client represent a host application talking to the
ME application, ME application can support multiple connections.
4. Add debug helpers

Tracked-On: projectacrn#1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw pushed a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: mei: add reset handlers
2a26541 
There are multiple types of resets that need to be handled
by the mei device.
The reset may be initiated from both sides host or fw.
The host requests reset on probe and remove,
power state transaction, and errors,
while ME FW may request reset upon error.
If the native device undergo reset the host application
has to be notified.

Tracked-On: projectacrn#1536
Signed-off-by: Aviad Nissel <aviad.nissel@intel.com>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw added a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: mei: add virtio cfgread/cfgwrite handlers.
64faea4 
mei mediator perform reset handshake via
the cfgread/write handlers and provide access
to fw status registers.

Tracked-On: projectacrn#1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw added a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: mei: add me clients enumeration
36f4262 
ME client enumeration is received from sysfs attributes
of the native device.

V3: Use bounded functions.

Tracked-On: projectacrn#1536
Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw added a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: mei: add native io handlers
19e3dec 
Add read write and connect handler,
that perform io peration on SOS /dev/meiX
device.

Tracked-On: projectacrn#1536
Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw added a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: mei: implement HBM protocol handler
1f4e924 
Implement the FW part of the HBM protocol.
Currently the support version is 2.0.
The HBM protocol handles client management, such
initialization handshake, connection, power management,
and the flow control.

Tracked-On: projectacrn#1536
Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw added a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: mei: implement tx flow
18f0924 
TX from virtio driver is handled firt via
virio tx notify handler vmei_notify_tx(),
placed into host clinet tx circular buffer.
TX thread will then write the data to the device.

Tracked-On: projectacrn#1536
Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw added a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: mei: implement rx flow.
0f4d667 
Rx is triggered from epoll event (mevent), a host client
is retrieved from associated event data. P proper mei message header is
attached to the packet and sent to the virtio FE device.

Tracked-On: projectacrn#1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw added a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: mei: implement vmei_start/stop()
e3c9894 
In vmei_start() the HBM host client is created,
it handles HBM protocol.
The HBM client is a management object and
is not exposed by the mei native driver.
The communication between TX and RX threads
is handed via internal pipe(2).
Second, we connect all fixed address clients as the mei
protocol doesn't provide connection mechanism for them,
they appear always connected.
Last, the hw_ready is set.

Define virtio_mei_ops, ass all the handlers are now available.

Tracked-On: projectacrn#1536
Signed-off-by: Liu Shuo <shuo.a.liu@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw added a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: mei: add module initialization
6c1591d 
Register virtio device virtio-mei.

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

Tracked-On: projectacrn#1536
Signed-off-by: Liu Shuo <shuo.a.liu@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw added a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: mei: enable virtio_mei compilation
1b378fc 
Add virtio_mei to the Makefile

Tracked-On: projectacrn#1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
tomasbw pushed a commit to tomasbw/acrn-hypervisor that referenced this issue Oct 20, 2018
@tomasbw
dm: launch_uos.sh add virtio_mei mediator
a07d722 
Detect if SOS kernel mei drivers supports virtualization,
via driver hbm version 2.2
If yes use virtio_mei mediator for the mei device
otherwise fallback to passthrou mode.
Note that HBM version is not sufficient identification

Tracked-On: projectacrn#1536
Signed-off-by: Aviad Nissel <aviad.nissel@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
@tomasbw tomasbw mentioned this issue Oct 22, 2018
Merged
@mwang106 mwang106 added the type: feature New feature label Oct 22, 2018
@mwang106
Copy link
Contributor

mwang106 commented Oct 23, 2018 •
edited by Mingyuan18
Loading

[External_System_ID] ACRN-2183

@mwang106 mwang106 added area: device model priority: medium status: new The issue status: new for creation labels Oct 23, 2018
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@tomasbw @wenlingz
dm: remove virtio_heci
0cc50b1 
Remove virtio_heci to be replaced with virtio_mei

Tracked-On: #1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@tomasbw @wenlingz
dm: mei: add mei hbm protocol definitions header.
d141aeb 
HBM is a control channel protocol between mei device
driver and mei fw.

Add new ioctl IOCTL_MEI_CONNECT_CLIENT_VTAG

Tracked-On: #1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@ausyskin @wenlingz
dm: mei: add guid handling functions
4e057c3 
libuuid sports only uuid (big endian encoding),
though mei requires guids (little endian encoding).
The base types are based on <linux/uuid.h> header.

Tracked-On: #1536
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@tomasbw @wenlingz
dm: types: add container_of macro
6a96878 
Add standard container_of macro to access
the parent struct pointer.

Tracked-On: #1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@tomasbw @wenlingz
dm: mei: add reference counter functions
b8d53d1 
mei handles objects on the list, hence reference counting
infrastructure is required for easier multithreading.

Tracked-On: #1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@tomasbw @wenlingz
dm: mei: add sysfs read functions
0dc7adf 
mei requires reading of u8, u32 and uuid
sysfs files.

Tracked-On: #1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@tomasbw @wenlingz
dm: mei: add virtio configuration
445f419 
The virtio has two virtio queues, TX and RX.
TX have two segment buffers one for header and one for data.
The virtio_mei declares host buffer of size 128 slots, each
slot is a 4 bytes value.
For synchronization hw_ready and host_reset configuration flags
are used that emulates mei reset flow.
And last fw status registers must be also readable via virtio
mei device.

Tracked-On: #1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@tomasbw @wenlingz
dm: mei: add client management infrastructure
a632ac3 
1. virtio_mei structure represents an instance of mei device.
2. vmei_me_client represents an ME application in the MEI FW.
3. vmei_host_client represent a host application talking to the
ME application, ME application can support multiple connections.
4. Add debug helpers

Tracked-On: #1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@wenlingz
dm: mei: add reset handlers
f462601 
There are multiple types of resets that need to be handled
by the mei device.
The reset may be initiated from both sides host or fw.
The host requests reset on probe and remove,
power state transaction, and errors,
while ME FW may request reset upon error.
If the native device undergo reset the host application
has to be notified.

Tracked-On: #1536
Signed-off-by: Aviad Nissel <aviad.nissel@intel.com>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@tomasbw @wenlingz
dm: mei: add virtio cfgread/cfgwrite handlers.
7cbb387 
mei mediator perform reset handshake via
the cfgread/write handlers and provide access
to fw status registers.

Tracked-On: #1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@tomasbw @wenlingz
dm: mei: add me clients enumeration
3abbf10 
ME client enumeration is received from sysfs attributes
of the native device.

V3: Use bounded functions.

Tracked-On: #1536
Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@tomasbw @wenlingz
dm: mei: add native io handlers
98c6b7a 
Add read write and connect handler,
that perform io peration on SOS /dev/meiX
device.

Tracked-On: #1536
Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@tomasbw @wenlingz
dm: mei: implement HBM protocol handler
483a893 
Implement the FW part of the HBM protocol.
Currently the support version is 2.0.
The HBM protocol handles client management, such
initialization handshake, connection, power management,
and the flow control.

Tracked-On: #1536
Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@tomasbw @wenlingz
dm: mei: implement tx flow
50ecd93 
TX from virtio driver is handled firt via
virio tx notify handler vmei_notify_tx(),
placed into host clinet tx circular buffer.
TX thread will then write the data to the device.

Tracked-On: #1536
Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@tomasbw @wenlingz
dm: mei: implement rx flow.
6a1f824 
Rx is triggered from epoll event (mevent), a host client
is retrieved from associated event data. P proper mei message header is
attached to the packet and sent to the virtio FE device.

Tracked-On: #1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@tomasbw @wenlingz
dm: mei: implement vmei_start/stop()
f6e6e85 
In vmei_start() the HBM host client is created,
it handles HBM protocol.
The HBM client is a management object and
is not exposed by the mei native driver.
The communication between TX and RX threads
is handed via internal pipe(2).
Second, we connect all fixed address clients as the mei
protocol doesn't provide connection mechanism for them,
they appear always connected.
Last, the hw_ready is set.

Define virtio_mei_ops, ass all the handlers are now available.

Tracked-On: #1536
Signed-off-by: Liu Shuo <shuo.a.liu@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@tomasbw @wenlingz
dm: mei: add module initialization
d4b9bd5 
Register virtio device virtio-mei.

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

Tracked-On: #1536
Signed-off-by: Liu Shuo <shuo.a.liu@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@tomasbw @wenlingz
dm: mei: enable virtio_mei compilation
201e5ce 
Add virtio_mei to the Makefile

Tracked-On: #1536
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Oct 23, 2018
@wenlingz
dm: launch_uos.sh add virtio_mei mediator
7ca1a7d 
Detect if SOS kernel mei drivers supports virtualization,
via driver hbm version 2.2
If yes use virtio_mei mediator for the mei device
otherwise fallback to passthrou mode.
Note that HBM version is not sufficient identification

Tracked-On: #1536
Signed-off-by: Aviad Nissel <aviad.nissel@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Wang, Yu1 <yu1.wang@intel.com>
@Mingyuan18 Mingyuan18 added status: closed The issue been closed and removed status: new The issue status: new for creation labels Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomasbw tomasbw

Labels
area: device model priority: medium status: closed The issue been closed type: feature New feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomasbw @mwang106 @Mingyuan18