Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TGL][PTCM]Cache was not locked after post-RTVM power off and restart #5806

Closed
lifeix opened this issue Mar 3, 2021 · 2 comments
Closed

[TGL][PTCM]Cache was not locked after post-RTVM power off and restart #5806

lifeix opened this issue Mar 3, 2021 · 2 comments
Labels
status: new The issue status: new for creation

Comments

@lifeix
Copy link
Contributor

lifeix commented Mar 3, 2021

No description provided.

@lifeix lifeix added the status: new The issue status: new for creation label Mar 3, 2021
@lifeix
Copy link
Contributor Author

lifeix commented Mar 3, 2021 •
edited by gvancuts

[External_System_ID] ACRN-6955

lifeix added a commit to lifeix/acrn-hypervisor that referenced this issue Mar 3, 2021
@lifeix
hv: cpu: remove cache_flush_invalidate_all in cpu_dead
8a55920 
Before the ACRN HV entered the S3, we would call cache_flush_invalidate_all to
flush all the caches into memory and invalidate the caches on each logical cpu
before we halt the cpu.

This was not a problem before we support pSRAM. Once pSRAM binary code has been
executed on the logical cpu, we could not flush the pSRAM cache into memory then.
Otherwise, the pSRAM cache can't been locked.

This patch removes cache_flush_invalidate_all in cpu_dead since we would not
support to put the ACRN HV into S3. Once we want to support put the ACRN HV into
S3, we would try other ways to flush the data caches in this cpu into memory and
valid whether that way is practical or not.

Signed-off-by: Li Fei1 <fei1.li@intel.com>
Tracked-On: projectacrn#5806
@lifeix lifeix mentioned this issue Mar 3, 2021
Merged
acrnsi-robot pushed a commit that referenced this issue Mar 3, 2021
@lifeix @acrnsi-robot
hv: cpu: remove cache_flush_invalidate_all in cpu_dead
23d8202 
Before the ACRN HV entered the S3, we would call cache_flush_invalidate_all to
flush all the caches into memory and invalidate the caches on each logical cpu
before we halt the cpu.

This was not a problem before we support pSRAM. Once pSRAM binary code has been
executed on the logical cpu, we could not flush the pSRAM cache into memory then.
Otherwise, the pSRAM cache can't been locked.

This patch removes cache_flush_invalidate_all in cpu_dead since we would not
support to put the ACRN HV into S3. Once we want to support put the ACRN HV into
S3, we would try other ways to flush the data caches in this cpu into memory and
valid whether that way is practical or not.

Signed-off-by: Li Fei1 <fei1.li@intel.com>
Tracked-On: #5806
@NanlinXie
Copy link
Contributor

Closed with no regression issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: new The issue status: new for creation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lifeix @NanlinXie