Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot send <break> key (null character) to Service VM virtual console #8583

Open
zhangqiang4 opened this issue Apr 22, 2024 · 1 comment
Open

Cannot send <break> key (null character) to Service VM virtual console #8583

zhangqiang4 opened this issue Apr 22, 2024 · 1 comment
Labels
status: new The issue status: new for creation

Comments

@zhangqiang4
Copy link
Contributor

zhangqiang4 commented Apr 22, 2024 •
edited
Loading

Steps

boot acrn with debug serial port
enter vm_console to enter Service VM virtual serial console
Can not send break key to Service VM any more because it's the magic key to exit from VM console to hypervisor console.

Potential Impact (Not found by test)

Some debug feature depends on key (like sysrq key, kdb) can't be used, which impacts ServiceVM debug a lot.
@zhangqiang4 zhangqiang4 added the status: new The issue status: new for creation label Apr 22, 2024
zhangqiang4 added a commit to zhangqiang4/acrn-hypervisor that referenced this issue Apr 22, 2024
@zhangqiang4
debug: vuart: add guest break key support
299a58c 
The break key (key value 0x0) was used as switch key from guest serial
to hv console and guest serial could not receive break key. This blocked
some guest debugging features like KGDB/KDB, sysrq, etc.

This patch leverages escape sequence "<escape> + <break>" to send break to
guest and "<escape> + e" to switch from guest serial to hv console.

Tracked-On: projectacrn#8583
Signed-off-by: Qiang Zhang <qiang4.zhang@intel.com>
zhangqiang4 added a commit to zhangqiang4/acrn-hypervisor that referenced this issue Apr 22, 2024
@zhangqiang4
debug: vuart: fix interrupt ID for data receiving
2dcbf18 
When RX FIFO is not empty and Receive Data Available interrupt is
enabled, vUART should report a Receive Data Available (IIR_RXRDY) in IIR
instead of a Timeout Interrupt Pending (IIR_RXTOUT).

Tracked-On: projectacrn#8583
Signed-off-by: Qiang Zhang <qiang4.zhang@intel.com>
zhangqiang4 added a commit to zhangqiang4/acrn-hypervisor that referenced this issue Apr 22, 2024
@zhangqiang4
debug: vuart: add guest break key support
5b49155 
The break key (key value 0x0) was used as switch key from guest serial
to hv console and guest serial could not receive break key. This blocked
some guest debugging features like KGDB/KDB, sysrq, etc.

This patch leverages escape sequence "<escape> + <break>" to send break to
guest and "<escape> + e" to switch from guest serial to hv console.

Tracked-On: projectacrn#8583
Signed-off-by: Qiang Zhang <qiang4.zhang@intel.com>
Reviewed-by: Junjie Mao <junjie.mao@intel.com>
zhangqiang4 added a commit to zhangqiang4/acrn-hypervisor that referenced this issue Apr 22, 2024
@zhangqiang4
debug: vuart: fix interrupt ID for data receiving
c7ce1c9 
When RX FIFO is not empty and Receive Data Available interrupt is
enabled, vUART should report a Receive Data Available (IIR_RXRDY) in IIR
instead of a Timeout Interrupt Pending (IIR_RXTOUT).

Tracked-On: projectacrn#8583
Signed-off-by: Qiang Zhang <qiang4.zhang@intel.com>
Reviewed-by: Junjie Mao <junjie.mao@intel.com>
@zhangqiang4
Copy link
Contributor Author

[External_System_ID] ACRN-10181

acrnsi-robot pushed a commit that referenced this issue Apr 25, 2024
@zhangqiang4 @acrnsi-robot
debug: vuart: add guest break key support
c623e11 
The break key (key value 0x0) was used as switch key from guest serial
to hv console and guest serial could not receive break key. This blocked
some guest debugging features like KGDB/KDB, sysrq, etc.

This patch leverages escape sequence "<escape> + <break>" to send break to
guest and "<escape> + e" to switch from guest serial to hv console.

Tracked-On: #8583
Signed-off-by: Qiang Zhang <qiang4.zhang@intel.com>
Reviewed-by: Junjie Mao <junjie.mao@intel.com>
acrnsi-robot pushed a commit that referenced this issue Apr 25, 2024
@zhangqiang4 @acrnsi-robot
debug: vuart: fix interrupt ID for data receiving
629808c 
When RX FIFO is not empty and Receive Data Available interrupt is
enabled, vUART should report a Receive Data Available (IIR_RXRDY) in IIR
instead of a Timeout Interrupt Pending (IIR_RXTOUT).

Tracked-On: #8583
Signed-off-by: Qiang Zhang <qiang4.zhang@intel.com>
Reviewed-by: Junjie Mao <junjie.mao@intel.com>
zhangqiang4 added a commit to zhangqiang4/acrn-hypervisor that referenced this issue Jun 11, 2024
@zhangqiang4
doc: update doc for vUART to hypervisor console switch key
21f0dc3 
Things changed since following commit
(c623e11 debug: vuart: add guest break key support).

Tracked-On: projectacrn#8583
Signed-off-by: Qiang Zhang <qiang4.zhang@intel.com>
@zhangqiang4 zhangqiang4 mentioned this issue Jun 11, 2024
Merged
zhangqiang4 added a commit to zhangqiang4/acrn-hypervisor that referenced this issue Jun 11, 2024
@zhangqiang4
doc: update doc for vUART to hypervisor console switch key
ebf174c 
Things changed since following commit
(c623e11 debug: vuart: add guest break key support).

Tracked-On: projectacrn#8583
Signed-off-by: Qiang Zhang <qiang4.zhang@intel.com>
zhangqiang4 added a commit to zhangqiang4/acrn-hypervisor that referenced this issue Jun 11, 2024
@zhangqiang4
doc: update doc for vUART to hypervisor console switch key
40372d0 
Things changed since following commit
(c623e11 debug: vuart: add guest break key support).

Tracked-On: projectacrn#8583
Signed-off-by: Qiang Zhang <qiang4.zhang@intel.com>
zhangqiang4 added a commit to zhangqiang4/acrn-hypervisor that referenced this issue Jun 14, 2024
@zhangqiang4
doc: update doc for vUART to hypervisor console switch key
1d51731 
Things changed since following commit
(c623e11 debug: vuart: add guest break key support).

Tracked-On: projectacrn#8583
Signed-off-by: Qiang Zhang <qiang4.zhang@intel.com>
wenlingz pushed a commit that referenced this issue Jun 25, 2024
@zhangqiang4 @wenlingz
doc: update doc for vUART to hypervisor console switch key
29137b9 
Things changed since following commit
(c623e11 debug: vuart: add guest break key support).

Tracked-On: #8583
Signed-off-by: Qiang Zhang <qiang4.zhang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: new The issue status: new for creation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhangqiang4