-
Notifications
You must be signed in to change notification settings - Fork 71
Conversation
In order for the OpenShift provider to natively support atomicapp we need to pass in a flag that identifies the image as an openshift self-executing job. We also have to instruct OpenShift to pass in user auth token so we can run oc as that user.
A couple of thoughts here. I'd actually like the labels to not be specific to openshift in case other providers would like to benefit from these labels in a similar way. Perhaps we can transform them into something like:
My new label proposals may not make sense but maybe we can come up with something that isn't openshift specific that does? @smarterclayton @aweiteka what do you think? |
The point of the labels being specific to openshift is that they are only used in one context - the OpenShift new-app generator. In the future, making these labels generic is great - but for that, there needs to be use of them. We can always add more labels, but I'm generally not in support of making generic things and hoping people use them. I want to make concrete things and prove their utility. I would prefer these to be openshift specific for now. |
Fair enough. I just don't want to deal with migration issues in the future if we decide to move to a more generic labeling scheme. I guess since we have a heavy influence in the openshift community it would be easier to change there than if we were working with some community where we didn't have influence. |
On the other hand, a LABEL is just a label, no one will hinder some 3rd party platform/provider/... to evaluate a label called |
doc and test (plan) are missing, otherwise LGTM |
Add OpenShift LABELs to enable native Atomic App support
Initial code is here openshift/origin#5378 |
In order for the OpenShift provider to natively
support atomicapp we need to pass in a flag that
identifies the image as an openshift self-executing
job. We also have to instruct OpenShift to pass
in user auth token so we can run oc as that user.
cc @smarterclayton to confirm LABEL correct key=value