This repository has been archived by the owner on Mar 22, 2018. It is now read-only.
ContainerManagerService #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashcrow
force-pushed
the
container-manager-service
branch
from
922f248
to
4dc7cbc
Compare
ashcrow
force-pushed
the
container-manager-service
branch
3 times, most recently
from
315bd9c
to
75c5d40
Compare
This service owns container management functions such as registering a node to a container manager. It follows a similar mechanic to the StorageService in that it is configurable to work with different backend systems using a handler plugin pattern.
ashcrow
force-pushed
the
container-manager-service
branch
from
75c5d40
to
465bc67
Compare
|
@mbarnes ⬆️ |
|
This will need updating based on the changes in prerequisite PR. |
|
@ashcrow: As a follow-up, can you also update the |
|
|
mbarnes
approved these changes
Dec 8, 2016
|
@mbarnes updated to catch |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new
ContainerManagerServicewhich provides the following remote calls:node_registered: Checks to see if a node has been registered via theContainerHandler.register_node: Registers a new node using theContainerHandler.remove_node: Removes a node using theContainerHandler.get_node_status: Gets the status of the node according to theContainerHandler.Requires: projectatomic/commissaire#66 and projectatomic/commissaire#68
Force a retest when the above have both merged.