Skip to content
This repository has been archived by the owner on Feb 2, 2018. It is now read-only.

ContainerManagerService updates. #66

Merged
merged 4 commits into from
Dec 6, 2016
Merged

ContainerManagerService updates. #66

merged 4 commits into from
Dec 6, 2016

Conversation

ashcrow
Copy link
Collaborator

@ashcrow ashcrow commented Dec 2, 2016 •
edited

  • StorageHandlers no longer handle container work.
  • Various clean up items.
  • Added check_config to KubeContainerManager.
  • ContainerHandlers now use friendly class names instead of using the generic names,

@ashcrow ashcrow changed the title WIP: StorageService WIP: ContainerManagerService updates. Dec 2, 2016
@ashcrow ashcrow added the WIP label Dec 2, 2016
@ashcrow
Copy link
Collaborator Author

ashcrow commented Dec 2, 2016

(5) [multi-host-mgr-2] Create ContainerManager Service

@ashcrow ashcrow force-pushed the container-manager-service branch 3 times, most recently from abe37c9 to b20ae01 Compare December 2, 2016 20:39
@ashcrow
storage: StorageHandlers no longer handle container work.
050e063
@ashcrow
containermgr: Various clean up items.
111c8c1
@ashcrow
containermgr: Added check_config to KubeContainerManager.
d2ca709 
KubeContainerManager now has a check_config class method which is used
via initialization. This change also introduces tests for
KubeContainerManager.
@ashcrow ashcrow mentioned this pull request Dec 6, 2016
Merged
@ashcrow ashcrow changed the title WIP: ContainerManagerService updates. ContainerManagerService updates. Dec 6, 2016
@ashcrow ashcrow removed the WIP label Dec 6, 2016
@ashcrow
Copy link
Collaborator Author

ashcrow commented Dec 6, 2016

@mbarnes PTAL

mbarnes
mbarnes approved these changes Dec 6, 2016
View reviewed changes
Copy link
Contributor

@mbarnes mbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll keep an eye out for the follow-ups.

@mbarnes mbarnes merged commit 9b3cf0f into projectatomic:master Dec 6, 2016
@ashcrow ashcrow mentioned this pull request Dec 9, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbarnes mbarnes mbarnes approved these changes

Assignees

@mbarnes mbarnes

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashcrow @mbarnes