Skip to content
This repository has been archived by the owner on Jan 19, 2018. It is now read-only.

Removing graph(s) in favour of app-name #210

Closed
cdrage opened this issue Jun 7, 2016 · 5 comments
Closed

Removing graph(s) in favour of app-name #210

cdrage opened this issue Jun 7, 2016 · 5 comments
Labels

Comments

@cdrage
Copy link
Member

cdrage commented Jun 7, 2016

graph:
  - name: mariadb-centos7-atomicapp
    source: docker://projectatomic/mariadb-centos7-atomicapp

  - name: helloapache-app
    params:
      - name: image
        description: The webserver image
        default: centos/httpd
      - name: hostport
        description: The host TCP port as the external endpoint
        default: 80
    artifacts:
      docker:
        - file://artifacts/docker/hello-apache-pod_run
      kubernetes:
        - file://artifacts/kubernetes/hello-apache-pod.json
      openshift:
        - inherit:
          - kubernetes
      marathon:
        - file://artifacts/marathon/helloapache.json

to

mariadb-centos7-atomicapp:
    source: docker://projectatomic/mariadb-centos7-atomicapp

helloapache-app:
    params:
      - name: image
        description: The webserver image
        default: centos/httpd
      - name: hostport
        description: The host TCP port as the external endpoint
        default: 80
    artifacts:
      docker:
        - file://artifacts/docker/hello-apache-pod_run
      kubernetes:
        - file://artifacts/kubernetes/hello-apache-pod.json
      openshift:
        - inherit:
          - kubernetes
      marathon:
        - file://artifacts/marathon/helloapache.json
@goern
Copy link
Contributor

goern commented Jun 7, 2016

any rational on this?

@cdrage
Copy link
Member Author

cdrage commented Jun 7, 2016

Clarity and way easier to learn. Consistent with a compose style model of launching an application.

Thoughts @dustymabe ?

@goern
Copy link
Contributor

goern commented Jun 7, 2016

so you encode the name of the graph as an element name, I dont know if I would put that on the 'clarity list' ;)

@cdrage
Copy link
Member Author

cdrage commented Jun 7, 2016

@goern Are you able to clarify what you mean? Example please? :)

I know you specify -name but it's much simpler for clarity if you specify via an actual app name instead.

@goern goern added the wontfix label Jun 7, 2016
@goern
Copy link
Contributor

goern commented Jun 7, 2016

There is no example, please see kubernetes/kubernetes#2004 and #35 why we have made the decision how to design the things as the are.

@goern goern closed this as completed Jun 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants