Initial commits of blacklight-maps gem #1
Conversation
| <!-- map goes here --> | ||
| <%= show_map_div() %> | ||
| <div id="leaflet-sidebar"></div> | ||
| <%= javascript_tag "var docs = #{@response.docs.to_json};" %> |
There was a problem hiding this comment.
Perhaps we can come up with a more lightweight serialization of the document array since we already know the fields that we'll need through configuration (e.g. title, latlong, placename, etc). This could balloon up in size for large responses of complex documents.
There was a problem hiding this comment.
Hopefully that's what @jcoyne was looking at in https://github.com/sul-dlss/spotlight/tree/list_of_points, and I think/hope we can get the detailed results view from an AJAX request to catalog#index
There was a problem hiding this comment.
Updated to only include needed mapping fields. https://github.com/sul-dlss/blacklight-maps/blob/setup/app/helpers/blacklight_maps_helper.rb
For the BL default seed data (30 records) this reduces the size of the JS object (stringified) from 17,028 bytes to 3,160 bytes (82% reduction)
|
Changes Unknown when pulling 9e29b799ed92d3456d3d979b4790e0cdfede1d19 on setup into * on master*. |
|
Changes Unknown when pulling ead1a034c823bba42a2494cf1c005edebbe1d8a0 on setup into * on master*. |
|
Changes Unknown when pulling ead1a034c823bba42a2494cf1c005edebbe1d8a0 on setup into * on master*. |
|
Changes Unknown when pulling ead1a034c823bba42a2494cf1c005edebbe1d8a0 on setup into * on master*. |
|
Changes Unknown when pulling ead1a034c823bba42a2494cf1c005edebbe1d8a0 on setup into * on master*. |
|
+1. I think it's good enough to ship and then clean up. I'll leave some inline comments for discussion, but I think we can address them in later PRs. |
|
|
||
| gem 'simplecov', require: false | ||
| gem 'coveralls', require: false | ||
|
|
||
| gem 'engine_cart', git: 'https://github.com/cbeer/engine_cart' |
There was a problem hiding this comment.
I suspect this gem engine_cart can get dropped. The gemspec should be providing it, right?
There was a problem hiding this comment.
@cbeer There was some reason I left it in there and now I can't remember. I'll look into it.
|
@jkeck this (still) has a 👍 from me. If you don't see any blockers, let's |
.
Initial commits of blacklight-maps gem 0.0.1
Would appreciate review by @jcoyne, @cbeer, and @jkeck