Render 404 when a facet isn't found.

projectblacklight · Sep 12, 2017 · 11e1e42 · 11e1e42
1 parent d9eb936
commit 11e1e42
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/app/controllers/concerns/blacklight/catalog.rb b/app/controllers/concerns/blacklight/catalog.rb
@@ -67,6 +67,7 @@ def track
     # displays values and pagination links for a single facet field
     def facet
       @facet = blacklight_config.facet_fields[params[:id]]
+      raise ActionController::RoutingError, 'Not Found' unless @facet
       @response = get_facet_field_response(@facet.key, params)
       @display_facet = @response.aggregations[@facet.field]
       @pagination = facet_paginator(@facet, @display_facet)

diff --git a/spec/controllers/catalog_controller_spec.rb b/spec/controllers/catalog_controller_spec.rb
@@ -541,6 +541,14 @@ def export_as_mock
         expect(assigns[:pagination].items.first['value']).to eq 'Book'
       end
     end
+
+    context 'when the requested facet is not in the configuration' do
+      it 'raises a routing error' do
+        expect {
+          get :facet, params: { id: 'fake' }
+        }.to raise_error ActionController::RoutingError, 'Not Found'
+      end
+    end
   end
 
   describe "#add_to_search_history" do