Deprecate render_index_field_value and just use the presenter

projectblacklight · Jul 7, 2016 · 45132b1 · 45132b1
1 parent 24c5241
commit 45132b1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/app/helpers/blacklight/blacklight_helper_behavior.rb b/app/helpers/blacklight/blacklight_helper_behavior.rb
@@ -160,18 +160,21 @@ def render_index_field_label *args
   #   @param [String] field
   #   @param [Hash] opts
   #   @options opts [String] :value
-  # TODO: deprecate and use render_field_value
+  # @deprecated use IndexPresenter#field_value
   def render_index_field_value *args
     render_field_value(*args)
   end
+  deprecation_deprecate render_index_field_value: 'replaced by IndexPresenter#field_value'
 
+  # @deprecated use IndexPresenter#field_value
   def render_field_value(*args)
     options = args.extract_options!
     document = args.shift || options[:document]
 
     field = args.shift || options[:field]
     presenter(document).field_value field, options.except(:document, :field)
   end
+  deprecation_deprecate render_field_value: 'replaced by IndexPresenter#field_value'
 
   ##
   # Render the show field label for a document

diff --git a/app/views/catalog/_index_default.html.erb b/app/views/catalog/_index_default.html.erb
@@ -1,10 +1,11 @@
+<% doc_presenter = index_presenter(document) %> 
 <%# default partial to display solr document fields in catalog index view -%>
 <dl class="document-metadata dl-horizontal dl-invert">
 
   <% index_fields(document).each do |field_name, field| -%>
     <% if should_render_index_field? document, field %>
 	    <dt class="blacklight-<%= field_name.parameterize %>"><%= render_index_field_label document, field: field_name %></dt>
-	    <dd class="blacklight-<%= field_name.parameterize %>"><%= render_index_field_value document, field: field_name %></dd>
+	    <dd class="blacklight-<%= field_name.parameterize %>"><%= doc_presenter.field_value field_name %></dd>
     <% end -%>
   <% end -%>